[Geany-devel] Changed file saving implementation for systems with GIO

[Nick Treleaven]

On Wed, 10 Nov 2010 21:23:18 +0200
Dimitar Zhekov <dimitar.zhekov at gmail.com> wrote:

> > > Why fake 0 errno as EIO? g_file_set_contents() doesn't, and *strerror()
> > > returns something for 0, usually "Error 0".
> > 
> > GLib says to use g_strerror, which says 'Success', which is confusing.
> 
> It is, but "Input/output error" usually means a failed disk. (o_O)
> POSIX says "Some physical input or output error has occurred."

Ok, so it's not great.

> > > Mind if I try to improve the error handling, using gfileutils.c as a
> > > source? There will be 3 new translation strings.
> > 
> > Sure, have a go.
> 
> Here. errno 0 still displays "Success" at the end of the messages, but
> at least they start "Failed to"... Well, it's identical to glib,
> including the paranoid resetting of errno before each call.

Applied, thanks.

> Tested with writing to /boza, full disk and a fake close error.

Thanks for testing.

Nick