[Geany-devel] HTML/XML autoindentation - Re: [PATCH] Some editor/snippets/keybindings enhancements

[Eugene Arshinov]

On Wed, 10 Nov 2010 17:51:18 +0000%
Nick Treleaven <nick.treleaven at btinternet.com> wrote:

> On Tue, 2 Nov 2010 23:28:43 +0300
> Eugene Arshinov <earshinov at gmail.com> wrote:
> 
> > > I think just add a html_tag_autoindentation field to
> > > GeanyFiletypePrivate and use that.
> > > 
> > 
> > Okay, the patch is attached.
> 
> Thanks, applied (with some changes).
> 
> > I named the field 'xml_indent_tags' and
> > the filetype property 'indent_tags'.  By default (like all fields in
> > GeanyFiletypePrivate) it is zero, but in global
> > filetypes.{xml,html} I set it to true.
> 
> I changed the filetype property to xml_indent_tags also, I think it's
> clearer.
> 
> I changed the code slightly to check whether the document uses the
> HTML/XML lexer rather than those filetypes, and to always read the
> property. This should allow other filetypes that have XML syntax to
> work also if the property is set.

Agree.  Thanks for update and commit.

> 
> BTW, should we set xml_indent_tags=true for PHP, Docbook filetypes?
> 

I think, yes, we should.  I attach a patch that have this changes plus
some documentation in geany.txt (if you use this patch, please
regenerate geany.html yourself as my rst2html causes most of this file
to be changed).

Best regards,
Eugene.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: geany.26.xml_autoindent_filetype_pref_additions.r5395.patch
Type: text/x-patch
Size: 2666 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20101110/86267c30/attachment.bin>