[Geany-devel] GtkRecentManager slowness - Re: [patch] Improved documents list sorting

[lists.ban at herbesfolles.org]

> On Thu, 29 Apr 2010 18:47:41 +0200, Colomban wrote:
>
>> Nick Treleaven a écrit :
>> > On Thu, 29 Apr 2010 17:46:45 +0200
>> > Enrico Tröger <enrico.troeger at uvena.de> wrote:
>> >
>> >>> Yes, I think it could be a (hidden?) option at least until it got
>> >>> fixed at the GTK level. Note that anyway it is only available if
>> >>> Geany was compiled against GTK >= 2.12.
>> >> Which is probably true for most Geany users (using GTK >= 2.12).
>> >
>> > (After a quick Grep it seems to me it's 2.10, not 2.12).
>> Yes, actually. I don't know why I've said 2.12 sorry.
>>
>> >> Maybe we could generally disable calling
>> >> gtk_recent_manager_add_item() when opening more than one file at
>> >> once because maybe the user doesn't want to have them added at
>> >> all. Though, no idea if this is a valid assumption and also no
>> >> idea how to verify it :).
>> I don't think so. I use that recent files feature, not that much but I
>> use it. And I would be definitely surprised if a file is added to it
>> if I open it alone but not if I open another file together.
>> But of course if we open 15 files and only 10 are shown in the recent
>> list, the first 5 might haven't be added at all. It would probably be
>> a little tricky to do that but it's probably the less wrong
>> workaround.
>
> I'm not sure what you mean. Only add the last 10 files when opening
> multiple files at once?
Yes. Or even better than "the last 10", the number returned by
gtk_recent_manager_get_limit().

> Another idea:
> maybe we could add a similar workaround as you did in your patch you
> attached to the GTK bug report:
> we 'collect' filenames added to the GtkRecentManager instead of adding
> them directly and then add them bulky in an idle function. That
> wouldn't really solve the problem but at least put the IO heavy part
> into one block at the end of loading files.
Hum, yes it's an idea, but as you said there still will be the problem, it
will only happen later. I'm not sure it would be better, but without
testing it is probably impossible to say.

Regards,
Colomban


PS: I'll probably be a little unresponsive these days because of some
problem with my computer hardware
 hope it'll be fixed soon.