[Geany-devel] [Patch] - Improve PHP parser (call tips)

[Lex Trotman]

Gentlemen please, no flame wars.

@Can, Thomas is correct, a commit can't be undone, even if its revented the
message is still in the records.  Better to concentrate on explaining why
the regex needs changing.  Everyone makes mistakes.

@Enrico, Nick and Can are right, the regex [abc|def] matches any one of
characters 'a', 'b', 'c', '|', 'd', 'e', 'f' not the sequences "abc or "def"
that (abc|def) matches.  There is no way of grouping without saving a match
unless the regex engine supports the non-capturing (?:  ) operator.

Cheers
Lex

On 9 March 2010 07:15, Can Koy <cankoy at ymail.com> wrote:

> well, who the hell are you?
>
>
> --- On Mon, 3/8/10, Thomas Martitz <thomas.martitz at student.HTW-Berlin.de>
> wrote:
>
> > From: Thomas Martitz <thomas.martitz at student.HTW-Berlin.de>
> > Subject: Re: [Geany-devel] [Patch] - Improve PHP parser (call tips)
> > To: geany-devel at uvena.de
> > Date: Monday, March 8, 2010, 7:46 PM
> > Am 08.03.2010 20:23, schrieb Can
> > Koy:
> > >
> > >> From: Nick Treleaven<nick.treleaven at btinternet.com>
> > >> Subject: Re: [Geany-devel] [Patch] - Improve PHP
> > parser (call tips)
> > >> To: geany-devel at uvena.de
> > >> Date: Monday, March 8, 2010, 12:18 PM
> > >> On Sun, 7 Mar 2010 19:20:37 +0100
> > >> Enrico Tröger<enrico.troeger at uvena.de>
> > >> wrote:
> > >>
> > >>
> > >>>> You put a weird pattern:
> > >>>> [public|protected|private|static]*
> > >>>> If you wanted to group, you should use ()
> > >>>>
> > >>> I didn't want to group, we don't need to know
> > the actual modifier, we
> > >>> just want to allow only this subset. And yes,
> > it was a group before but
> > >>> there is just no need to.
> > >>>
> > >> I think Can is right, [] brackets are only for
> > character ranges, not
> > >> string matching. So () brackets are necessary for
> > matching even when
> > >> ignoring the group.
> > >>
> > >>
> > > Actually, I'm very uncomfortable with my name being
> > recorded in that patch's log (r4729). That regex is funny,
> > it exhibits an ignorance in the subject and it's not what I
> > submitted. So, I demand my name removed from the logs for
> > that patch.
> > >
> > > --
> > > Can Koy
> > >
> > >
> > >
> >
> >
> > Then please submit a patch to the subversion project to
> > enable
> > post-editing of commit messages, since this is not possible
> > currently.
> >
> > But honestly, I don't see why this is a big deal. Maybe we
> > can
> > concentrate on improving Geany and not insisting on minor
> > things like this.
> >
> > Best regards.
> > _______________________________________________
> > Geany-devel mailing list
> > Geany-devel at uvena.de
> > http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
> >
>
>
>
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20100309/ba8db2df/attachment.html>