[Geany-devel] [Patch] - Improve PHP parser (call tips)

[Dominic Hopf]

Am Montag, den 08.03.2010, 12:15 -0800 schrieb Can Koy:
> well, who the hell are you?
Can, Thomas is contributing to the Geany project for a very long time.
As developer as well as a tester. I do not see any reason to ask such
questions here. Especially not in that caustically way.

> > > Actually, I'm very uncomfortable with my name being
> > recorded in that patch's log (r4729). That regex is funny,
> > it exhibits an ignorance in the subject and it's not what I
> > submitted. So, I demand my name removed from the logs for
> > that patch.
Maybe it could be, Enrico modified some things on your patch before he
commited it, I don't know. If this is the case, he maybe forgot to write
the commit message as "based on patch from ..." as he usually does.
Well, that could happen to anyone, we're all just humans. So, thanks
very much for your understanding.

Anyway, Enrico has every right to modify code before applying it onto
Geany. As you may have noticed he is one of the main authors of Geany
and initiated the project. He still is one of the last ones who decide
if code makes it into Geany or not. Geany is Free Software under GPL and
any contribution should be too. Thus I see no reason why patches may not
be modified before applying them to the project. If the modification is
an improvement or not is a technical question which I am not asking for
at present. We're open to discuss any technical issue. :)

[snip]
> > Then please submit a patch to the subversion project to
> > enable 
> > post-editing of commit messages, since this is not possible
> > currently.
> > 
> > But honestly, I don't see why this is a big deal. Maybe we
> > can 
> > concentrate on improving Geany and not insisting on minor
> > things like this.

The fact that your name is mentioned in the commit message can not be
undone due to the technical reasons Thomas wrote. I'm afraid you will
have to live with that. Please keep in mind that Free Software projects
are not mainly intended to make someones name public or not. Such
projects are intended to provide good software for the user. - Thus a
lot of your patches we're very appreciated. - In most Free Software
projects it is the case, that the developers actually are people who
have very long working days and do their efforts for the projects in
their free time after work. This actually is also the case for the Geany
project. I think, a bit of understanding from your side would be
appreciated by anyone here. Mistakes can happen to anyone.

Regards,
Dominic

-- 
Dominic Hopf <dmaphy at googlemail.com>

http://dominichopf.de/

Key Fingerprint:
A7DF C4FC 07AE 4DDC 5CA0 BD93 AAB0 6019 CA7D 868D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.geany.org/pipermail/devel/attachments/20100308/ac4f5f82/attachment.pgp>