[Geany-devel] [Patch] - Improve PHP parser (call tips)

[Enrico Tröger]

On Fri, 5 Mar 2010 12:21:25 -0800 (PST), Can wrote:

>Hi,
>The following patch adds call tips for functions in PHP code.
>The regex pattern for function parameters is not optimal, but should
>work for most cases. When you have a problem, send the relevant
>function definition so that I can improve the patch.

Awesome (though I still think it'd be better in thelong term to write
a C-based, real parser insteaf of fiddling with regexps).

I tweaked the patch a bit to work also with functions wth a modifier
(public, private, ...) as it worked before (which was a patch by
Harold, IIRC). I hope I didn't put more bugs into it than before :).
Also, there might be cases where the code could crash due to invalid
memory accesses, these have to be found.

For the meantime, committed.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20100307/222498b8/attachment.pgp>