[Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog.

[Lex Trotman]

Can,

BTW I have never even seen this dialog, so for finding it, and noticing the
inconsistency, and trying to do something about it you deserve thanks for
the effort.

Maybe you should be promoted to user interface quality manager :-)

Cheers
Lex

On 2 March 2010 09:53, Can Koy <cankoy at ymail.com> wrote:

> OK, you send a patch then.
>
> --- On Mon, 3/1/10, Lex Trotman <elextr at gmail.com> wrote:
>
> > From: Lex Trotman <elextr at gmail.com>
> > Subject: Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave
> Missing File dialog.
> > To: "Geany development list" <geany-devel at uvena.de>
> > Date: Monday, March 1, 2010, 9:55 PM
> >
> >
> > On 2 March 2010 05:25, Can Koy
> > <cankoy at ymail.com>
> > wrote:
> >
> > This patch fixes keyboard accelerator on Resave Missing
> > File dialog.
> >
> >
> >
> >
> >
> > I have a couple of problems with this patch, sorry if they
> > applied to some of your previous ones but I didn't have
> > time to look at them before.
> >
> > 1. Terminology only, this is changing the mnemonic, not the
> > keyboard accelerator, although the GTK docs are not totally
> > consistent about it :-)
> >
> >
> > A mnemonic is the character you type (usually with Alt) to
> > activate a visible menu or dialog item and must be unique
> > only within a single menu or dialog, a keyboard accelerator
> > is a keycode (like ctrl-shift-w) that activates
> > functionality directly, visible or not and must be globally
> > unique within Geany.
> >
> >
> > 2. The standard mnemonic for close is always 'c'
> > which is adhered to in most applications and other Geany
> > dialogs, but this patch is changing this one from the
> > standard, this is not good user interface practice, if
> > 'c' clashes then the other should be changed, its
> > 'closes' mnemonic
> >
> >
> > 3. by changing it from the stock item there is no icon
> > associated with the button, again non-standard and won't
> > match the other buttons
> >
> > Cheers
> > Lex
> >
> >
> >
> > _______________________________________________
> >
> > Geany-devel mailing list
> >
> > Geany-devel at uvena.de
> >
> > http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
> >
> >
> >
> >
> >
> > -----Inline Attachment Follows-----
> >
> > _______________________________________________
> > Geany-devel mailing list
> > Geany-devel at uvena.de
> > http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
> >
>
>
>
>
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20100302/069081a0/attachment.html>