[Geany-devel] [PATCH 19/19] Use per document indent sizes

[Lex Trotman]

On 10 August 2010 07:45, Jiří Techet <techet at gmail.com> wrote:
> On Sun, Aug 8, 2010 at 04:40, Erik de Castro Lopo
> <mle+tools at mega-nerd.com> wrote:
>> Erik de Castro Lopo wrote:
>>
>>> Jiri,
>>>
>>> I've applied this patch to my own tree and I'm not sure its working
>>> as it should.
>>>
>>> When I have a document open (with default tabs width set to 4) and I use
>>> your menu item to set the document to 8 I expect the indent to switch
>>> from 4 to 8 but that doesn't happen.
>>>
>>> Did my cherry picking of this patch miss out something that was in one
>>> of the other patches?
>>
>>
>> Hmm, for some reason your code expected "_8" while on my machine I
>> was getting "4". The attached patch handles both variants.
>
> Interesting.
>
> I wanted to avoid 8 callback functions for each menu entry by reading
> the label but apparently it wasn't a good idea. When thinking about
> it, the label can be localized and completely changed so I shouldn't
> rely on its value.
>
> Instead of using your patch I think it's cleaner to really use the 8
> callbacks which should fix all the problems. So please use the
> attached patch instead of the original one.

Hi Jiri,

While this works fine and the handlers are only one line each, another
way would have been to use one handler and set different user_data for
each menu item.

Cheers
Lex

>
> Cheers,
>
> Jiri
>
>>
>> Cheers,
>> Erik
>> --
>> ----------------------------------------------------------------------
>> Erik de Castro Lopo
>> http://www.mega-nerd.com/
>>
>> _______________________________________________
>> Geany-devel mailing list
>> Geany-devel at uvena.de
>> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>>
>>
>
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>
>