[Geany-devel] [PATCH] fix memory leak
daniel.marjamaki at xxxxx
Thu Aug 5 20:14:15 UTC 2010
I believe this will fix a memory leak in src/search.c. But please double-check!
At lines 1417-1422 the search_text is allocated:
if (enc != NULL && g_utf8_validate(utf8_search_text, utf8_text_len, NULL))
search_text = g_convert(utf8_search_text, utf8_text_len, enc,
"UTF-8", NULL, NULL, NULL);
if (search_text == NULL)
search_text = g_strdup(utf8_search_text);
The only usage of search_text between the lines 1417-1456 is:
argv_prefix[i++] = g_strdup(search_text);
At line 1456 there is this code:
if (argv == NULL) /* no files */
I assume that a "g_free(search_text);" is needed before the return.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 280 bytes
Desc: not available
More information about the Devel