[Geany-devel] Reflow & long lines

[Eugene Arshinov]

Hi.

The truth is that I did not notice the former setting until now, so I
did not consider it when writing initial split-and-join-lines patch.

My opinion is that _like breaking column_ should be used when
document->line breaking is checked, otherwise _long line marker_ should
be used:

// split_lines() function, keybindings.c
gint edge;
if (editor->line_breaking)
    edge = editor_prefs.line_break_column;
else if (editor->long_line_type != 2)
    /* long-line marker is enabled */
    edge = editor_prefs.long_line_column;
else
    /* nothing to do */
    return;

BUT, I don't know a case when it's useful to set line break column and
long-line column to different values. As to me, I'd prefer this to be
one setting.

Best regards,
Eugene.

On Tue, 22 Sep 2009 17:51:06 +1000
Lex Trotman <elextr at gmail.com> wrote:

> Hi Frank,
> 
> I'm talking about the two settings in:
> 
> Preferences->editor->features: Line Breaking column
> 
> and
> 
> Preferences->editor->display: Long line marker
> 
> The former is where lines are broken when typing with
> Menu->Document->line breaking checked.
> 
> Cheers
> Lex
> 
> 2009/9/22 Frank Lanitz <frank at frank.uvena.de>:
> > On Tue, 22 Sep 2009 15:53:21 +1000
> > Lex Trotman <elextr at gmail.com> wrote:
> >
> >> Hi,
> >>
> >> A suggestion on the reflow block function.
> >>
> >> Currently it appears to use the long-lines marker column as its
> >> right edge, but I would have expected it to use the line breaking
> >> column so that it is consistent with newly typed input.
> >>
> >> What do others think?
> >
> > Can you give an example as I'm not sure what you refer to with line
> > breaking column.
> >
> > Thanks,
> > Frank
> > --
> > Frank Lanitz <frank at frank.uvena.de>
> > _______________________________________________
> > Geany-devel mailing list
> > Geany-devel at uvena.de
> > http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
> >
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel