[Geany-devel] Creating ~/.config/geany/filedefs/filetypes.* files - Re: ANN: Configurable build beta in trunk

[Enrico Tröger]

On Tue, 1 Sep 2009 15:39:09 +0100, Nick wrote:

>On Tue, 1 Sep 2009 15:37:51 +0100
>Nick Treleaven <nick.treleaven at btinternet.com> wrote:
>
>> > > I just noticed that all user filetypes files are always created
>> > > and saved, just by quitting Geany. The previous behaviour was to
>> > > only create/save a filetypes file if the user had pressed OK in
>> > > the Build Commands dialog *for that filetype*. Could this be
>> > > implemented?
>> > 
>> > Yes.  I think it should be, but its mildly non-trivial.
>> > 
>> > It would require extra fields in GeanyFiletypesPrivate (? and
>> > GeanyFiletype ?) to record if any of the regexes are changed so
>> > that writting of the file can be prevented only if the regex isn't
>> > changed. And the dialogs need additions to set them.
>> 
>> That's not necessary IMO - surely if the dialog is never shown or
>> Cancel is pressed, nothing is changed? We could just set a private
>> flag for the filetype if OK was clicked.
>
>Obviously this way you may get a false positive if the user didn't
>change anything and just pressed OK but this makes it much easier to
>implement and avoids a lot of unnecessary files on disk.

I fully agree here. The previous behaviour where only real changes were
written into user config files were better.


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20090901/2f9866a4/attachment.pgp>