[Geany-devel] Strip trailing blank lines (patch included)

Enrico Tröger enrico.troeger at xxxxx
Sat Aug 29 10:27:27 UTC 2009


On Thu, 27 Aug 2009 21:35:20 +0400, Eugene wrote:

>Hi Enrico.
>
>Enrico Tro"ger wrote:
>> On Wed, 26 Aug 2009 19:48:30 +0400, Eugene wrote:
>>
>> Hey,
>>
>>   
>>> I wrote new `editor_strip_trailing_newlines' function (see the
>>> attached patch). Currently I call it directly from
>>> `document_save_file' if `strip_trailing_spaces' setting is set. Of
>>> course, it's not how it should be. Maybe separate menu item and
>>> option should be added, like for trailing spaces. Alternative way
>>> is to combine those, i.e., rename "Strip trailing spaces" to "Remove
>>> excessive whitespace" :-) These all are usability issues, with
>>> which I don't like to deal. If any of the developers has an opinion
>>> upon those, I'll consider it and update the patch.
>>>     
>>
>> Hmm, I'm not sure that would be an often used feature but of course
>> it can be useful and you already wrote the code (and used it on the
>> modified files in your patch...I like to have two or three trailing
>> blank links at EOF :D).
>> Back to the topic, what about putting this into a plugin?
>>
>> Either as a separate plugin which might be a bit overhead, or as part
>> of the addons plugin which aims to collect such small pieces of
>> additions or as a new (core) plugin into which we could move the
>> existing other both related features, too.
>>
>> Just some thoughts. Opinions?
>Putting it to the addons plugin sounds reasonable. I'll do it this or 
>next week.

Cool.
If you want SVN write access to commit your changes yourself, just tell
me your Sourceforge username (and give me a a little time to set it
up :D).


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20090829/c77eb02d/attachment.pgp>


More information about the Devel mailing list