[Geany-devel] tab close icon - Re: SF.net SVN: geany:[3244] trunk

[Colomban Wendling]

Enrico Tröger a écrit :
> On Thu, 20 Nov 2008 16:42:35 +0000, Nick Treleaven
> <nick.treleaven at btinternet.com> wrote:
>
>   
>> On Tue, 18 Nov 2008 17:03:15 +0000
>> eht16 at users.sourceforge.net wrote:
>>
>>     
>>> Revision: 3244
>>>           http://geany.svn.sourceforge.net/geany/?rev=3244&view=rev
>>> Author:   eht16
>>> Date:     2008-11-18 17:03:15 +0000 (Tue, 18 Nov 2008)
>>>
>>> Log Message:
>>> -----------
>>> Remove forced size requests for the tab close icon as it seems not
>>> necessary and broke the icon on Windows.
>>>       
>> Although I'm not bothered at the moment, this commit makes the tab bar
>> taller by about 8-10 pixels on my machine. But on my laptop the tab
>> close button was slightly cropped before, haven't tried the new code
>> yet though.
>>     
>
> Weird.
> But at least the old code broke the icon on Windows completely, there
> it was only a little dot. Now it is shown properly (on my system at
> least).
>
> The current code is pretty much the same as what Midori and Gedit are
> using so I thought it might be safe and works on most systems.
>
> Nick, could you check which value GTK_ICON_SIZE_MENU has on your system?
>
> Does anyone else have problems with the tab close icon size?
>
> Regards,
> Enrico
>   

Hi,

On my system (Debian Lenny using an ubuntulooks-based theme, GTK 2.12)
the tabs are now 4 pixels taller than GEdit's or gnome-terminal's ones
(29px vs 25px).
GEdit's close icons are cropped but gnome-terminal ones are not.

For me ICON_SIZE_MENU seems to be 16×16 (according to the GDK Window's
size of a rendered stock image).

Regards,
Colomban