[geany/geany] b7bd5f: Correct the backport of UniqueStringSet::Save to Scintilla 3.x. (String comparison was intended, not identity.) Fixes #2883. (#2884)

Justin Blanchard git-noreply at xxxxx
Thu Sep 2 22:21:12 UTC 2021


Branch:      refs/heads/master
Author:      Justin Blanchard <UncombedCoconut at gmail.com>
Committer:   GitHub <noreply at github.com>
Date:        Thu, 02 Sep 2021 22:21:12 UTC
Commit:      b7bd5fa38ef832451dc8ca22d8ae1d9aa10fb4c1
             https://github.com/geany/geany/commit/b7bd5fa38ef832451dc8ca22d8ae1d9aa10fb4c1

Log Message:
-----------
Correct the backport of UniqueStringSet::Save to Scintilla 3.x. (String comparison was intended, not identity.) Fixes #2883. (#2884)


Modified Paths:
--------------
    scintilla/src/UniqueString.cxx

Modified: scintilla/src/UniqueString.cxx
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -43,7 +43,7 @@ const char *UniqueStringSet::Save(const char *text) {
 		return nullptr;
 
 	for (const UniqueString &us : strings) {
-		if (text == us.get()) {
+		if (strcmp(us.get(), text) == 0) {
 			return us.get();
 		}
 	}



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Commits mailing list