[geany/geany] 106784: build_menu_update: Only enable next/prev error items when errors found

[Nick Treleaven]

Branch:      refs/heads/master
Author:      Nick Treleaven <n at trelsoft.com>
Committer:   Nick Treleaven <n at trelsoft.com>
Date:        Tue, 08 Oct 2019 13:22:20 UTC
Commit:      1067841a7bf83a895416ba75fa1067dd4e418d7b
             https://github.com/geany/geany/commit/1067841a7bf83a895416ba75fa1067dd4e418d7b

Log Message:
-----------
build_menu_update: Only enable next/prev error items when errors found


Modified Paths:
--------------
    src/build.c

Modified: src/build.c
4 lines changed, 3 insertions(+), 1 deletions(-)
===================================================================
@@ -1471,7 +1471,9 @@ void build_menu_update(GeanyDocument *doc)
 		doc = document_get_current();
 	have_path = doc != NULL && doc->file_name != NULL;
 	build_running =  build_info.pid > (GPid) 1;
-	have_errors = gtk_tree_model_iter_n_children(GTK_TREE_MODEL(msgwindow.store_compiler), NULL) > 0;
+	// note: compiler list store may have been cleared since last build
+	have_errors = build_info.message_count > 0 &&
+		gtk_tree_model_iter_n_children(GTK_TREE_MODEL(msgwindow.store_compiler), NULL) > 0;
 	for (i = 0; build_menu_specs[i].build_grp != MENU_DONE; ++i)
 	{
 		struct BuildMenuItemSpec *bs = &(build_menu_specs[i]);



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).