[geany/geany-osx] 15c0f3: Create bundle signature directly using codesign

Jiří Techet git-noreply at xxxxx
Thu Dec 22 14:03:00 UTC 2016


Branch:      refs/heads/master
Author:      Jiří Techet <techet at gmail.com>
Committer:   Jiří Techet <techet at gmail.com>
Date:        Thu, 22 Dec 2016 14:03:00 UTC
Commit:      15c0f3e5cc841cb47101fb59273d51d4734e0ae3
             https://github.com/geany/geany-osx/commit/15c0f3e5cc841cb47101fb59273d51d4734e0ae3

Log Message:
-----------
Create bundle signature directly using codesign

The method used by gtk-mac-bundler doesn’t seem to work for all OS X
versions (e.g. doesn’t work on 10.10.5). Signing directly with codesign
seems to work now - though the signature probably isn’t “right” because
libraries are in resource directories and therefore signed as resources
instead of binaries (the “right” signature for binaries signs every code
page independently so signatures can be verified lazily as the code
gets loaded instead of all the code at the launch time).


Modified Paths:
--------------
    README.md
    create_dmg.sh

Modified: README.md
23 lines changed, 15 insertions(+), 8 deletions(-)
===================================================================
@@ -169,25 +169,32 @@ Bundling
 
 	from within the geany-osx directory.
 
-5.	Optionally if you have a development account at Apple and want to sign the
+5.	Create the app bundle by calling
+
+	```
+	gtk-mac-bundler geany.bundle
+	```
+
+	from within the geany-osx directory.
+
+6.	Optionally if you have a development account at Apple and want to sign the
 	resulting bundle so it can be started without warning dialogs, use
 
 	```
-	export APPLICATION_CERT="your certificate name"
+	export SIGN_CERTIFICATE="your certificate name"
 	```
 
 	The certificate should be installed in your login keychain. You can get the
 	certificate name by running `security find-identity -p codesigning` and
-	checking  for "Developer ID Application" - the name that follows it is the
-	certificate name.
+	checking  for "Developer ID Application" - the whole name in apostrophes is
+	the certificate name.
 
-6.	Create the app bundle by calling
+	Then run
 
 	```
-	gtk-mac-bundler geany.bundle
+	codesign -s $SIGN_CERTIFICATE --deep --force ./Geany.app
 	```
 
-	from within the geany-osx directory.
 
 Distribution
 ------------
@@ -203,7 +210,7 @@ Distribution
 	./create_dmg.sh
 	```
 
-	from within the geany-osx directory. If the APPLICATION_CERT variable is
+	from within the geany-osx directory. If the SIGN_CERTIFICATE variable is
 	defined, the image gets signed by the specified certificate.
 
 Maintenance


Modified: create_dmg.sh
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -29,5 +29,5 @@ rm -rf "${TMPDIR}"
 
 if [ -n "$APPLICATION_CERT" ]
 then
-	codesign -s "$APPLICATION_CERT" "$DMGNAME"
+	codesign -s "$SIGN_CERTIFICATE" "$DMGNAME"
 fi



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Commits mailing list