[geany/geany] e38b80: stash: Fix invalid free in sync from object property

Colomban Wendling git-noreply at xxxxx
Wed Jun 3 12:45:29 UTC 2015


Branch:      refs/heads/master
Author:      Colomban Wendling <ban at herbesfolles.org>
Committer:   Colomban Wendling <ban at herbesfolles.org>
Date:        Wed, 03 Jun 2015 12:45:29 UTC
Commit:      e38b803ccde65f40fc25b1c21edde82bf67cdaf8
             https://github.com/geany/geany/commit/e38b803ccde65f40fc25b1c21edde82bf67cdaf8

Log Message:
-----------
stash: Fix invalid free in sync from object property


Modified Paths:
--------------
    src/stash.c

Modified: src/stash.c
5 lines changed, 3 insertions(+), 2 deletions(-)
===================================================================
@@ -694,8 +694,9 @@ static void handle_widget_property(GtkWidget *widget, StashPref *entry,
 			break;
 		case PREF_UPDATE:
 			if (entry->setting_type == G_TYPE_STRING)
-				g_free(entry->setting);
-			/* TODO: Which other types need freeing here? */
+				g_free(*(gchararray*)entry->setting);
+			else if (entry->setting_type == G_TYPE_STRV)
+				g_strfreev(*(gchararray**)entry->setting);
 
 			g_object_get(object, name, entry->setting, NULL);
 			break;



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Commits mailing list