[geany/geany] 6f5d5d: Disable "maintain history on reload" by default

[Colomban Wendling]

Branch:      refs/heads/master
Author:      Colomban Wendling <ban at herbesfolles.org>
Committer:   Colomban Wendling <ban at herbesfolles.org>
Date:        Wed, 08 Jul 2015 15:54:34 UTC
Commit:      6f5d5db2cb6da4970aa78a64efee3a91727fea51
             https://github.com/geany/geany/commit/6f5d5db2cb6da4970aa78a64efee3a91727fea51

Log Message:
-----------
Disable "maintain history on reload" by default

While the feature is nice, it might be unexpected and lacks user
feedback.  This might lead to user thinking they lost their work
because they don't know they can undo the reload operation.

So, disable the feature by default until we introduce appropriate user
feedback allowing the user to learn about the feature and new behavior.

See http://lists.geany.org/pipermail/devel/2015-June/thread.html#9537


Modified Paths:
--------------
    NEWS
    doc/geany.txt
    src/keyfile.c

Modified: NEWS
4 lines changed, 2 insertions(+), 2 deletions(-)
===================================================================
@@ -56,8 +56,8 @@ Geany 1.25 (unreleased)
     * Do not comment out blank lines when toggling comments (PR#79, Igor
       Shaula).
     * Improve handling of Verilog strings and comments.
-    * Keep undo history when reloading files (PR#188, Arthur
-      Rosenstein).
+    * Support for keeping undo history when reloading files (PR#188, Arthur
+      Rosenstein).  This is not enabled by default in this release.
 
     Search
     * Add support for single-line regular expressions (PR#310).


Modified: doc/geany.txt
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -2652,7 +2652,7 @@ use_gio_unsafe_file_saving        Whether to use GIO as the unsafe file        t
                                   correctly on some complex setups.
 gio_unsafe_save_backup            Make a backup when using GIO unsafe file     false       immediately
                                   saving. Backup is named `filename~`.
-keep_edit_history_on_reload       Whether to maintain the edit history when    true        immediately
+keep_edit_history_on_reload       Whether to maintain the edit history when    false       immediately
                                   reloading a file, and allow the operation
                                   to be reverted.
 **Filetype related**


Modified: src/keyfile.c
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -234,7 +234,7 @@ static void init_pref_groups(void)
 	stash_group_add_boolean(group, &file_prefs.use_gio_unsafe_file_saving,
 		"use_gio_unsafe_file_saving", TRUE);
 	stash_group_add_boolean(group, &file_prefs.keep_edit_history_on_reload,
-		"keep_edit_history_on_reload", TRUE);
+		"keep_edit_history_on_reload", FALSE);
 	/* for backwards-compatibility */
 	stash_group_add_integer(group, &editor_prefs.indentation->hard_tab_width,
 		"indent_hard_tab_width", 8);



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).