[geany/geany] e18d75: Change signal used to kill executions to SIGTERM

Lex git-noreply at xxxxx
Sat Mar 23 00:58:45 UTC 2013

Branch:      refs/heads/master
Author:      Lex <elextr at gmail.com>
Committer:   Lex <elextr at gmail.com>
Date:        Sat, 23 Mar 2013 00:58:45 UTC
Commit:      e18d75b23b33def5cef4ea35ba495e5544cd2c87

Log Message:
Change signal used to kill executions to SIGTERM

The originally used SIGQUIT has problems:
1) see the deleted comment
2) some xterm alternatives ignore it, so they don't stop

Changed to SIGTERM which is the canonical "terminate" signal.

Removed associated unneeded ignore of SIGQUIT.

Modified Paths:

Modified: src/build.c
5 files changed, 1 insertions(+), 4 deletions(-)
@@ -1779,9 +1779,6 @@ static void on_toolbutton_make_activate(GtkWidget *menuitem, gpointer user_data)
 static void kill_process(GPid *pid)
-	/* Unix: SIGQUIT is not the best signal to use because it causes a core dump (this should not
-	 * perforce necessary for just killing a process). But we must use a signal which we can
-	 * ignore because the main process get it too, it is declared to ignore in main.c. */
 	gint result;
 #ifdef G_OS_WIN32
@@ -1792,7 +1789,7 @@ static void kill_process(GPid *pid)
 	result = ! result;
 	g_return_if_fail(*pid > 1);
-	result = kill(*pid, SIGQUIT);
+	result = kill(*pid, SIGTERM);
 	if (result != 0)

Modified: src/main.c
2 files changed, 0 insertions(+), 2 deletions(-)
@@ -1057,8 +1057,6 @@ gint main(gint argc, gchar **argv)
     /* removed as signal handling was wrong, see signal_cb()
 	signal(SIGTERM, signal_cb); */
 #ifdef G_OS_UNIX
-	/* SIGQUIT is used to kill spawned children and we get also this signal, so ignore */
-	signal(SIGQUIT, SIG_IGN);
 	/* ignore SIGPIPE signal for preventing sudden death of program */
 	signal(SIGPIPE, SIG_IGN);

This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

More information about the Commits mailing list