[geany/geany] b1b882: Simplify updating Scintilla keywords on reload con...

Matthew Brush matt at xxxxx
Thu Oct 20 04:45:09 UTC 2011

  Branch: refs/heads/master
  Home:   https://github.com/geany/geany

  Commit: b1b88286cf2c71a1be8e0bccc207063e93755bbd
  Author: Matthew Brush <matt at geany.org>
  Date:   2011-10-19 (Wed, 19 Oct 2011)

  Changed paths:
    M src/callbacks.c
  M src/document.c
  M src/document.h

  Log Message:
  Simplify updating Scintilla keywords on reload config and tab switch.

Remove type keywords caching function since it doesn't really speed up
anything and we don't care if the keywords change since they can/should
still be reloaded.  This also prevents "leaking" a static GString once
when the application closes and saves a call to g_string_free() when the
type keywords have changed.

Rename document_update_highlighting() to document_update_type_keywords()
since no re-highlighting is needed when updating Scintilla keywords.
Scintilla highlights the new keywords automatically so this saves a call
to queue_colourise().

Remove update_type_keywords() function since this is now all handled
in the document_update_type_keywords() function.  This function had a
comment about updating all documents when sci is NULL but it was never
used in this way since it was only called on document_load_config() which
always operates on a single document and the sci should not be NULL.

More information about the Commits mailing list