SF.net SVN: geany:[5176] branches/Geany-0_19_1

[ntrel at users.sourceforge.net]

Revision: 5176
          http://geany.svn.sourceforge.net/geany/?rev=5176&view=rev
Author:   ntrel
Date:     2010-08-17 15:02:49 +0000 (Tue, 17 Aug 2010)

Log Message:
-----------
r5170 | ntrel | 2010-08-16 17:54:59 +0100 (Mon, 16 Aug 2010) | 2 lines

Fix saving non-project filetype error regex.

Modified Paths:
--------------
    branches/Geany-0_19_1/ChangeLog
    branches/Geany-0_19_1/src/build.c

Modified: branches/Geany-0_19_1/ChangeLog
===================================================================
--- branches/Geany-0_19_1/ChangeLog	2010-08-17 14:52:29 UTC (rev 5175)
+++ branches/Geany-0_19_1/ChangeLog	2010-08-17 15:02:49 UTC (rev 5176)
@@ -3,6 +3,8 @@
  * scintilla/LexMarkdown.cxx:
    Fix infinite loop in Markdown lexer (patch by Colomban Wendling,
    thanks).
+ * src/build.c:
+   Fix saving non-project filetype error regex.
 
 
 2010-08-15  Enrico Tröger  <enrico(dot)troeger(at)uvena(dot)de>

Modified: branches/Geany-0_19_1/src/build.c
===================================================================
--- branches/Geany-0_19_1/src/build.c	2010-08-17 14:52:29 UTC (rev 5175)
+++ branches/Geany-0_19_1/src/build.c	2010-08-17 15:02:49 UTC (rev 5176)
@@ -2549,12 +2549,12 @@
 }
 
 
+/* TODO: untyped ptr is too ugly (also for build_load_menu) */
 void build_save_menu(GKeyFile *config, gpointer ptr, GeanyBuildSource src)
 {
 	GeanyFiletype *ft;
 	GeanyProject *pj;
 	ForEachData data;
-	gchar *regkey;
 
 	switch (src)
 	{
@@ -2564,12 +2564,10 @@
 				return;
 			build_save_menu_grp(config, ft->homefilecmds, GEANY_GBG_FT, NULL);
 			build_save_menu_grp(config, ft->homeexeccmds, GEANY_GBG_EXEC, NULL);
-			regkey = g_strdup_printf("%serror_regex", ft->name);
 			if (NZV(ft->homeerror_regex_string))
-				g_key_file_set_string(config, build_grp_name, regkey, ft->projerror_regex_string);
+				g_key_file_set_string(config, build_grp_name, "error_regex", ft->homeerror_regex_string);
 			else
-				g_key_file_remove_key(config, build_grp_name, regkey, NULL);
-			g_free(regkey);
+				g_key_file_remove_key(config, build_grp_name, "error_regex", NULL);
 			break;
 		case GEANY_BCS_PREF:
 			build_save_menu_grp(config, non_ft_pref, GEANY_GBG_NON_FT, NULL);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.