SF.net SVN: geany:[4214] trunk

[ntrel at users.sourceforge.net]

Revision: 4214
          http://geany.svn.sourceforge.net/geany/?rev=4214&view=rev
Author:   ntrel
Date:     2009-09-21 12:34:16 +0000 (Mon, 21 Sep 2009)

Log Message:
-----------
Speed up sorting in utils_get_file_list(). This reduces the file
browser delay on displaying a big directory, e.g. /usr/bin.

Modified Paths:
--------------
    trunk/ChangeLog
    trunk/src/utils.c

Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog	2009-09-20 19:09:24 UTC (rev 4213)
+++ trunk/ChangeLog	2009-09-21 12:34:16 UTC (rev 4214)
@@ -1,3 +1,10 @@
+2009-09-21  Nick Treleaven  <nick(dot)treleaven(at)btinternet(dot)com>
+
+ * src/utils.c:
+   Speed up sorting in utils_get_file_list(). This reduces the file
+   browser delay on displaying a big directory, e.g. /usr/bin.
+
+
 2009-09-20  Enrico Tröger  <enrico(dot)troeger(at)uvena(dot)de>
 
  * src/filetypes.c, src/filetypes.h, src/symbols.c,

Modified: trunk/src/utils.c
===================================================================
--- trunk/src/utils.c	2009-09-20 19:09:24 UTC (rev 4213)
+++ trunk/src/utils.c	2009-09-21 12:34:16 UTC (rev 4214)
@@ -1379,10 +1379,12 @@
 
 	foreach_dir(filename, dir)
 	{
-		list = g_slist_insert_sorted(list, g_strdup(filename), (GCompareFunc) utils_str_casecmp);
+		list = g_slist_append(list, g_strdup(filename));
 		len++;
 	}
 	g_dir_close(dir);
+	/* sorting last is quicker than on insertion */
+	list = g_slist_sort(list, (GCompareFunc) utils_str_casecmp);
 
 	if (length)
 		*length = len;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.