SF.net SVN: geany:[4366] trunk

[ntrel at users.sourceforge.net]

Revision: 4366
          http://geany.svn.sourceforge.net/geany/?rev=4366&view=rev
Author:   ntrel
Date:     2009-10-26 13:06:51 +0000 (Mon, 26 Oct 2009)

Log Message:
-----------
Don't install unnecessary headers: dialogs.h, main.h, plugins.h,
sciwrappers.h, build.h. (This helps to get compiler warnings for uses
of functions not in the API).
Warning: any plugins that include these headers should remove them.

Modified Paths:
--------------
    trunk/ChangeLog
    trunk/plugins/geanyplugin.h
    trunk/src/Makefile.am
    trunk/src/filetypes.h

Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog	2009-10-26 12:58:52 UTC (rev 4365)
+++ trunk/ChangeLog	2009-10-26 13:06:51 UTC (rev 4366)
@@ -3,6 +3,11 @@
  * src/prefs.h, src/search.h, src/support.h, src/templates.h,
    src/toolbar.c, src/toolbar.h:
    Add missing dox for types/files in the API.
+ * src/filetypes.h, src/Makefile.am, plugins/geanyplugin.h:
+   Don't install unnecessary headers: dialogs.h, main.h, plugins.h,
+   sciwrappers.h, build.h. (This helps to get compiler warnings for uses
+   of functions not in the API).
+   Warning: any plugins that include these headers should remove them.
 
 
 2009-10-25  Enrico Tröger  <enrico(dot)troeger(at)uvena(dot)de>

Modified: trunk/plugins/geanyplugin.h
===================================================================
--- trunk/plugins/geanyplugin.h	2009-10-26 12:58:52 UTC (rev 4365)
+++ trunk/plugins/geanyplugin.h	2009-10-26 13:06:51 UTC (rev 4366)
@@ -34,19 +34,16 @@
 #include "geany.h"
 #include "plugindata.h"
 
-#include "dialogs.h"
+/* only include headers that define types or macros, not just functions */
 #include "document.h"
 #include "editor.h"
 #include "encodings.h"
 #include "filetypes.h"
 #include "highlighting.h"
 #include "keybindings.h"
-#include "main.h"
 #include "msgwindow.h"
-#include "plugins.h"
 #include "prefs.h"
 #include "project.h"
-#include "sciwrappers.h"
 #include "search.h"
 #include "support.h"
 #include "templates.h"

Modified: trunk/src/Makefile.am
===================================================================
--- trunk/src/Makefile.am	2009-10-26 12:58:52 UTC (rev 4365)
+++ trunk/src/Makefile.am	2009-10-26 13:06:51 UTC (rev 4366)
@@ -51,29 +51,26 @@
 
 
 geany_includedir = $(includedir)/geany
+
+# only install headers that define types or macros, not just functions
 geany_include_HEADERS = \
-	dialogs.h \
 	document.h \
 	editor.h \
 	encodings.h \
 	filetypes.h \
+	geany.h \
 	highlighting.h \
 	keybindings.h \
-	geany.h \
-	main.h \
 	msgwindow.h \
-	plugins.h \
 	plugindata.h \
 	prefs.h \
 	project.h \
-	sciwrappers.h \
 	search.h \
 	support.h \
 	templates.h \
 	toolbar.h \
 	ui_utils.h \
-	utils.h \
-	build.h
+	utils.h
 
 
 INCLUDES = -I$(top_srcdir) -I$(srcdir)/../scintilla/include -I$(srcdir)/../tagmanager/include \

Modified: trunk/src/filetypes.h
===================================================================
--- trunk/src/filetypes.h	2009-10-26 12:58:52 UTC (rev 4365)
+++ trunk/src/filetypes.h	2009-10-26 13:06:51 UTC (rev 4366)
@@ -27,7 +27,10 @@
 
 #include "Scintilla.h"
 #include "ScintillaWidget.h"
+
+#ifdef GEANY_PRIVATE
 #include "build.h"
+#endif
 
 
 typedef enum


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.