SF.net SVN: geany:[3842] trunk

eht16 at users.sourceforge.net eht16 at xxxxx
Fri Jun 5 15:57:01 UTC 2009


Revision: 3842
          http://geany.svn.sourceforge.net/geany/?rev=3842&view=rev
Author:   eht16
Date:     2009-06-05 15:57:01 +0000 (Fri, 05 Jun 2009)

Log Message:
-----------
When closing a document, mark it as invalid before removing it from the documents notebook (this fixes wrong Save All button state when closing an unsaved document because the "switch-page" signal handler was using old data).

Modified Paths:
--------------
    trunk/ChangeLog
    trunk/src/document.c

Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog	2009-06-05 15:49:55 UTC (rev 3841)
+++ trunk/ChangeLog	2009-06-05 15:57:01 UTC (rev 3842)
@@ -17,6 +17,11 @@
    dashes (patch by PCMan, thanks).
  * data/filetypes.matlab:
    Add build_settings section to allow executing Matlab scripts.
+ * src/document.c:
+   When closing a document, mark it as invalid before removing it from
+   the documents notebook (this fixes wrong Save All button state when
+   closing an unsaved document because the "switch-page" signal handler
+   was using old data).
 
 
 2009-06-03  Nick Treleaven  <nick(dot)treleaven(at)btinternet(dot)com>

Modified: trunk/src/document.c
===================================================================
--- trunk/src/document.c	2009-06-05 15:49:55 UTC (rev 3841)
+++ trunk/src/document.c	2009-06-05 15:57:01 UTC (rev 3842)
@@ -672,6 +672,8 @@
 	if (! main_status.closing_all && doc->real_path != NULL)
 		ui_add_recent_file(doc->file_name);
 
+	doc->is_valid = FALSE;
+
 	notebook_remove_page(page_num);
 	treeviews_remove_document(doc);
 	navqueue_remove_file(doc->file_name);
@@ -687,7 +689,6 @@
 
 	document_stop_file_monitoring(doc);
 
-	doc->is_valid = FALSE;
 	doc->file_name = NULL;
 	doc->real_path = NULL;
 	doc->file_type = NULL;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.



More information about the Commits mailing list