SF.net SVN: geany: [2476] trunk

[eht16 at users.sourceforge.net]

Revision: 2476
          http://geany.svn.sourceforge.net/geany/?rev=2476&view=rev
Author:   eht16
Date:     2008-04-13 10:33:51 -0700 (Sun, 13 Apr 2008)

Log Message:
-----------
Fix wrong return value for on_close_all1_activate() callback.
Fix broken Close All command by not double checking for validity of a document.

Modified Paths:
--------------
    trunk/ChangeLog
    trunk/src/callbacks.c
    trunk/src/callbacks.h

Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog	2008-04-12 08:57:45 UTC (rev 2475)
+++ trunk/ChangeLog	2008-04-13 17:33:51 UTC (rev 2476)
@@ -1,3 +1,11 @@
+2008-04-13  Enrico Tröger  <enrico(dot)troeger(at)uvena(dot)de>
+
+ * src/callbacks.c, src/callbacks.h:
+   Fix wrong return value for on_close_all1_activate() callback.
+   Fix broken Close All command by not double checking for validity
+   of a document.
+
+
 2008-04-11  Enrico Tröger  <enrico(dot)troeger(at)uvena(dot)de>
 
  * THANKS, doc/geany.txt, doc/geany.html:

Modified: trunk/src/callbacks.c
===================================================================
--- trunk/src/callbacks.c	2008-04-12 08:57:45 UTC (rev 2475)
+++ trunk/src/callbacks.c	2008-04-13 17:33:51 UTC (rev 2476)
@@ -152,9 +152,11 @@
 	}
 	for (i = 0; i < len; i++)
 	{
-		if (doc_list[i].is_valid)
-			document_remove(0);
+		/* we don't need to check here for whether doc_list[i] is valid,
+		 * it's done in document_remove(). */
+		document_remove(0);
 	}
+
 	main_status.closing_all = FALSE;
 }
 
@@ -279,11 +281,11 @@
 }
 
 
-gboolean
+void
 on_close_all1_activate                 (GtkMenuItem     *menuitem,
                                         gpointer         user_data)
 {
-	return close_all();
+	close_all();
 }
 
 

Modified: trunk/src/callbacks.h
===================================================================
--- trunk/src/callbacks.h	2008-04-12 08:57:45 UTC (rev 2475)
+++ trunk/src/callbacks.h	2008-04-13 17:33:51 UTC (rev 2476)
@@ -102,7 +102,7 @@
 on_close1_activate                     (GtkMenuItem     *menuitem,
                                         gpointer         user_data);
 
-gboolean
+void
 on_close_all1_activate                 (GtkMenuItem     *menuitem,
                                         gpointer         user_data);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.