"& ui_prefs.fullscreen" was redundant, state brings "ui_prefs.fullscreen & interface_prefs.hide_menubar_on_fullscreen" from caller. Now with tabs..I think it's ok!
On Thu, 20 Oct 2011 12:43:15 +0100Looks fine to me, except that some of the changes are indented with
Pedro Cirne <pedro@cirne100.eu> wrote:
> Here it is...I hope it's useful!
>
> On Thu, Oct 20, 2011 at 1:55 AM, Lex Trotman <elextr@gmail.com> wrote:
>
> > On 20 October 2011 11:39, Pedro Cirne <pedro@cirne100.eu> wrote:
> > > I have edited the source code to make it works for me, is it useful for
> > the
> > > project?
> >
> > If you submit a patch/pull request we will certainly have a look at
> > it. Then you may not have to keep applying it each time Geany
> > upgrades.
spaces instead of tabs.
I'm not quite sure why ui_menubar_showhide() should take a gboolean
state, check it with & and hide the menu for state = 1 (or TRUE?). It
may be the most effective way, but writing an extra line or too to make
the code stupid and simple may be a good idea.
A good thing to have, though I personnaly am not going to use it.
--
E-gards: Jimmy
_______________________________________________
Geany mailing list
Geany@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany