Branch: refs/heads/master Author: Colomban Wendling ban@herbesfolles.org Committer: Colomban Wendling ban@herbesfolles.org Date: Wed, 17 Dec 2014 21:18:54 UTC Commit: 6f662377c88af3735ef653e4d3dc0878f16efc69 https://github.com/geany/geany-plugins/commit/6f662377c88af3735ef653e4d3dc08...

Log Message: ----------- webhelper: Fix a crash on GTK < 2.24

GTK < 2.24 had a bug leading to a crash when setting the tooltip of an entry icon before the icon itself. Work around it by setting the icon first.

See https://bugzilla.gnome.org/show_bug.cgi?id=606103

Modified Paths: -------------- webhelper/src/gwh-browser.c

Modified: webhelper/src/gwh-browser.c 3 lines changed, 1 insertions(+), 2 deletions(-) =================================================================== @@ -929,6 +929,7 @@ create_toolbar (GwhBrowser *self) gtk_widget_show_all (GTK_WIDGET (item));

self->priv->url_entry = gtk_bin_get_child (GTK_BIN (self->priv->url_combo)); + set_location_icon (self, NULL); gtk_entry_set_icon_tooltip_text (GTK_ENTRY (self->priv->url_entry), GTK_ENTRY_ICON_PRIMARY, _("Website information and settings")); @@ -943,8 +944,6 @@ create_toolbar (GwhBrowser *self) gtk_widget_set_sensitive (GTK_WIDGET (self->priv->item_next), FALSE); gtk_widget_set_sensitive (GTK_WIDGET (self->priv->item_cancel), FALSE);

- set_location_icon (self, NULL); - g_signal_connect_swapped (G_OBJECT (self->priv->item_prev), "clicked", G_CALLBACK (webkit_web_view_go_back), self->priv->web_view);

-------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).