Plugins-Commits February 2016

plugins-commits@lists.geany.org

1 participants
90 discussions

[geany/geany-plugins] 775632: debugger/gdb_mi: Improve implementation of parse_cstring()
by Colomban Wendling 07 Feb '16

07 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Sun, 07 Feb 2016 03:35:36 UTC Commit: 77563203d6eb0cea464a4b1745e368360e6d89fb https://github.com/geany/geany-plugins/commit/77563203d6eb0cea464a4b1745e36… Log Message: ----------- debugger/gdb_mi: Improve implementation of parse_cstring() Copy blocks as long as possible at once instead of byte by byte, e.g. everything between two escape sequences at once. This gives a speedup of about 8% on typical data with few escape sequences. Modified Paths: -------------- debugger/src/gdb_mi.c Modified: debugger/src/gdb_mi.c 10 lines changed, 8 insertions(+), 2 deletions(-) =================================================================== @@ -98,13 +98,17 @@ static gchar *parse_cstring(const gchar **p) if (**p == '"') { + const gchar *base; + (*p)++; + base = *p; while (**p != '"') { gchar c = **p; /* TODO: check expansions here */ if (c == '\\') { + g_string_append_len(str, base, (*p) - base); (*p)++; c = **p; switch (g_ascii_tolower(c)) @@ -159,12 +163,14 @@ static gchar *parse_cstring(const gchar **p) } break; } + g_string_append_c(str, c); + base = (*p) + 1; } - if (**p == '\0') + else if (**p == '\0') break; - g_string_append_c(str, c); (*p)++; } + g_string_append_len(str, base, (*p) - base); if (**p == '"') (*p)++; } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] de60a4: debugger/gdb_mi: Improve implementation of parse_string()
by Colomban Wendling 07 Feb '16

07 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Sun, 07 Feb 2016 03:35:36 UTC Commit: de60a4c48a36fb8a080e981a5b6917141c2863b7 https://github.com/geany/geany-plugins/commit/de60a4c48a36fb8a080e981a5b691… Log Message: ----------- debugger/gdb_mi: Improve implementation of parse_string() Simply copy the whole block at once instead of populating a buffer byte by byte. This gives a speedup of about 12% on typical data. Modified Paths: -------------- debugger/src/gdb_mi.c Modified: debugger/src/gdb_mi.c 8 lines changed, 4 insertions(+), 4 deletions(-) =================================================================== @@ -182,15 +182,15 @@ static gchar *parse_cstring(const gchar **p) * the docs aren't clear on this */ static gchar *parse_string(const gchar **p) { - GString *str = g_string_new(NULL); + const gchar *base = *p; if (g_ascii_isalpha(**p) || strchr("-_.", **p)) { - g_string_append_c(str, **p); for ((*p)++; g_ascii_isalnum(**p) || strchr("-_.", **p); (*p)++) - g_string_append_c(str, **p); + ; } - return g_string_free(str, FALSE); + + return g_strndup (base, *p - base); } /* parses: string "=" value */ -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] 95133e: debugger/gdb_mi: Do not allocate values when reading invalid input
by Colomban Wendling 07 Feb '16

07 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Sun, 07 Feb 2016 03:35:36 UTC Commit: 95133ee30874e100ddc641289f164eb4c9d0734b https://github.com/geany/geany-plugins/commit/95133ee30874e100ddc641289f164… Log Message: ----------- debugger/gdb_mi: Do not allocate values when reading invalid input Only allocate a value structure in parse_value() if the input actually contains a readable value, instead of destroying it if it doesn't. This is particularly useful as the implementation of parse_value() itself recurses in order to discriminate a value from a result, which means that a value would be allocated and freed immediately for each result in the input. This gives a speedup of about 10% on typical data. Modified Paths: -------------- debugger/src/gdb_mi.c Modified: debugger/src/gdb_mi.c 9 lines changed, 3 insertions(+), 6 deletions(-) =================================================================== @@ -211,15 +211,17 @@ static gboolean parse_result(struct gdb_mi_result *result, const gchar **p) * Actually, this is more permissive and allows mixed tuples/lists */ static struct gdb_mi_value *parse_value(const gchar **p) { - struct gdb_mi_value *val = g_malloc0(sizeof *val); + struct gdb_mi_value *val = NULL; if (**p == '"') { + val = g_malloc0(sizeof *val); val->type = GDB_MI_VAL_STRING; val->string = parse_cstring(p); } else if (**p == '{' || **p == '[') { struct gdb_mi_result *prev = NULL; + val = g_malloc0(sizeof *val); val->type = GDB_MI_VAL_LIST; gchar end = **p == '{' ? '}' : ']'; (*p)++; @@ -248,11 +250,6 @@ static struct gdb_mi_value *parse_value(const gchar **p) if (**p == end) (*p)++; } - else - { - gdb_mi_value_free(val); - val = NULL; - } return val; } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] d85193: debugger/gdb_mi: Test: allow for lines of arbitrary length
by Colomban Wendling 07 Feb '16

07 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Sun, 07 Feb 2016 03:35:36 UTC Commit: d851935f818994de1380252185a2359e982ea341 https://github.com/geany/geany-plugins/commit/d851935f818994de1380252185a23… Log Message: ----------- debugger/gdb_mi: Test: allow for lines of arbitrary length Modified Paths: -------------- debugger/src/gdb_mi.c Modified: debugger/src/gdb_mi.c 24 lines changed, 21 insertions(+), 3 deletions(-) =================================================================== @@ -482,17 +482,35 @@ static void gdb_mi_record_dump(const struct gdb_mi_record *record) gdb_mi_result_dump(record->first, TRUE, 2); } -int main(void) +static gchar *read_line(FILE *fp) { char buf[1024] = {0}; + GString *line = g_string_new(NULL); - while (fgets(buf, sizeof buf, stdin)) + while (fgets(buf, sizeof buf, fp)) { - struct gdb_mi_record *record = gdb_mi_record_parse(buf); + g_string_append(line, buf); + if (line->len < 1 || line->str[line->len - 1] == '\n') + break; + } + + return g_string_free(line, line->len < 1); +} + +int main(int argc, char **argv) +{ + gchar *line; + + while ((line = read_line(stdin)) != NULL) + { + struct gdb_mi_record *record = gdb_mi_record_parse(line); gdb_mi_record_dump(record); gdb_mi_record_free(record); + + g_free(line); } + return 0; } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] 297be8: debugger: Greatly improve Stack Tree population speed
by Colomban Wendling 07 Feb '16

07 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Sun, 07 Feb 2016 03:32:58 UTC Commit: 297be8db19e805238e8962c75aa2d74bf3cd8bbf https://github.com/geany/geany-plugins/commit/297be8db19e805238e8962c75aa2d… Log Message: ----------- debugger: Greatly improve Stack Tree population speed Appending elements to a TreeStore is very slow, while prepending them is fast. As we add all items at once, prepend elements in reverse order, which is a lot faster and does the same. This leads to tremendous speedups with large stack traces. For example, showing a 105000 frames height trace (resulting from infinite recursion and thus stack exhaustion) used to take more than 105s, while it now takes less than 0.3s. Modified Paths: -------------- debugger/src/debug.c debugger/src/stree.c debugger/src/stree.h Modified: debugger/src/debug.c 6 lines changed, 1 insertions(+), 5 deletions(-) =================================================================== @@ -700,11 +700,7 @@ static void on_debugger_stopped (int thread_id) /* get current stack trace and put in the tree view */ stack = active_module->get_stack(); - for (iter = stack; iter; iter = iter->next) - { - frame *f = (frame*)iter->data; - stree_add(f); - } + stree_add (stack); stree_select_first_frame(TRUE); /* files */ Modified: debugger/src/stree.c 19 lines changed, 14 insertions(+), 5 deletions(-) =================================================================== @@ -430,20 +430,29 @@ GtkWidget* stree_init(move_to_line_cb ml, select_frame_cb sf) } /* - * add frame to the tree view + * add frames to the tree view */ -void stree_add(frame *f) +void stree_add(GList *frames) { + GList *item; GtkTreeRowReference *reference = (GtkTreeRowReference*)g_hash_table_lookup(threads, (gpointer)active_thread_id); - GtkTreeIter frame_iter; GtkTreeIter thread_iter; GtkTreePath *path = gtk_tree_row_reference_get_path(reference); gtk_tree_model_get_iter(model, &thread_iter, path); gtk_tree_path_free(path); - gtk_tree_store_insert_before(store, &frame_iter, &thread_iter, 0); + g_object_ref (model); + gtk_tree_view_set_model (GTK_TREE_VIEW (tree), NULL); - gtk_tree_store_set (store, &frame_iter, S_FRAME, f, -1); + /* prepending is a *lot* faster than appending, so prepend with a reversed data set */ + for (item = g_list_last (frames); item; item = item->prev) + { + gtk_tree_store_insert_with_values (store, NULL, &thread_iter, 0, + S_FRAME, item->data, -1); + } + + gtk_tree_view_set_model (GTK_TREE_VIEW (tree), model); + g_object_unref (model); } /* Modified: debugger/src/stree.h 2 lines changed, 1 insertions(+), 1 deletions(-) =================================================================== @@ -31,7 +31,7 @@ GtkWidget* stree_init(move_to_line_cb ml, select_frame_cb sf); void stree_destroy(void); -void stree_add(frame *f); +void stree_add(GList *frames); void stree_clear(void); void stree_add_thread(int thread_id); -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] a3ccd4: debugger: Add reference counting to frame objects
by Colomban Wendling 07 Feb '16

07 Feb '16

1 0

[geany/geany-plugins] 19c421: debugger: stree: Cleanup stored columns
by Colomban Wendling 07 Feb '16

07 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Sun, 07 Feb 2016 03:31:38 UTC Commit: 19c4218a6e54e9fa36d48f9d7618cfbd03c0bd28 https://github.com/geany/geany-plugins/commit/19c4218a6e54e9fa36d48f9d7618c… Log Message: ----------- debugger: stree: Cleanup stored columns Store a frame pointer directly rather than a bunch of columns with the corresponding frame's value. This lowers memory duplication as well as the burden on the generic data model (GtkTreeModel). This results in a slight performance gain when adding frames, and cleans up some code. Modified Paths: -------------- debugger/src/stree.c Modified: debugger/src/stree.c 192 lines changed, 100 insertions(+), 92 deletions(-) =================================================================== @@ -42,12 +42,7 @@ /* Tree view columns */ enum { - S_ADRESS, - S_FUNCTION, - S_FILEPATH, - S_LINE, - S_LAST_VISIBLE, - S_HAVE_SOURCE, + S_FRAME, /* the frame if it's a frame, or NULL if it's a thread */ S_THREAD_ID, S_ACTIVE, S_N_COLUMNS @@ -69,9 +64,16 @@ static GtkWidget *tree = NULL; static GtkTreeModel *model = NULL; static GtkTreeStore *store = NULL; +static GtkTreeViewColumn *column_filepath = NULL; +static GtkTreeViewColumn *column_address = NULL; + /* cell renderer for a frame arrow */ static GtkCellRenderer *renderer_arrow = NULL; +static GType frame_get_type (void); +G_DEFINE_BOXED_TYPE(frame, frame, frame_ref, frame_unref) +#define STREE_TYPE_FRAME (frame_get_type ()) + /* * frame arrow clicked callback */ @@ -119,23 +121,23 @@ static gboolean on_query_tooltip(GtkWidget *widget, gint x, gint y, gboolean key gint start_pos, width; gtk_tree_view_column_cell_get_position(column, renderer_arrow, &start_pos, &width); - if (column == gtk_tree_view_get_column(GTK_TREE_VIEW(widget), S_FILEPATH)) + if (column == column_filepath) { - gchar *path = NULL; + frame *f; GtkTreeIter iter; gtk_tree_model_get_iter(model, &iter, tpath); - gtk_tree_model_get(model, &iter, S_FILEPATH, &path, -1); + gtk_tree_model_get(model, &iter, S_FRAME, &f, -1); - gtk_tooltip_set_text(tooltip, path); + gtk_tooltip_set_text(tooltip, f->file); gtk_tree_view_set_tooltip_row(GTK_TREE_VIEW(widget), tooltip, tpath); show = TRUE; - g_free(path); + frame_unref(f); } - else if (column == gtk_tree_view_get_column(GTK_TREE_VIEW(widget), S_ADRESS) && bx >= start_pos && bx < start_pos + width) + else if (column == column_address && bx >= start_pos && bx < start_pos + width) { gtk_tooltip_set_text(tooltip, gtk_tree_path_get_indices(tpath)[1] == active_frame_index ? _("Active frame") : _("Click an arrow to switch to a frame")); gtk_tree_view_set_tooltip_row(GTK_TREE_VIEW(widget), tooltip, tpath); @@ -165,14 +167,23 @@ static void on_render_arrow(GtkTreeViewColumn *tree_column, GtkCellRenderer *cel static void on_render_line(GtkTreeViewColumn *tree_column, GtkCellRenderer *cell, GtkTreeModel *tree_model, GtkTreeIter *iter, gpointer data) { - GtkTreePath *tpath = gtk_tree_model_get_path(model, iter); + frame *f; - if (1 == gtk_tree_path_get_depth(tpath)) - { + gtk_tree_model_get (model, iter, S_FRAME, &f, -1); + + if (! f) g_object_set(cell, "text", "", NULL); - } + else + { + GValue value = {0}; - gtk_tree_path_free(tpath); + g_value_init(&value, G_TYPE_INT); + g_value_set_int (&value, f->line); + g_object_set_property (G_OBJECT (cell), "text", &value); + + g_value_unset (&value); + frame_unref (f); + } } /* @@ -181,28 +192,22 @@ static void on_render_line(GtkTreeViewColumn *tree_column, GtkCellRenderer *cell static void on_render_filename(GtkTreeViewColumn *tree_column, GtkCellRenderer *cell, GtkTreeModel *tree_model, GtkTreeIter *iter, gpointer data) { - GtkTreePath *tpath = gtk_tree_model_get_path(model, iter); - - if (1 != gtk_tree_path_get_depth(tpath)) - { - gchar *path = NULL, *name; - gtk_tree_model_get(model, iter, S_FILEPATH, &path, -1); + frame *f; - name = path ? g_path_get_basename(path) : NULL; - g_object_set(cell, "text", name ? name : path, NULL); + gtk_tree_model_get(model, iter, S_FRAME, &f, -1); - g_free(name); - if (path) - { - g_free(path); - } - } + if (! f) + g_object_set(cell, "text", "", NULL); else { - g_object_set(cell, "text", "", NULL); - } + gchar *name; - gtk_tree_path_free(tpath); + name = f->file ? g_path_get_basename(f->file) : NULL; + g_object_set(cell, "text", name ? name : f->file, NULL); + + g_free(name); + frame_unref (f); + } } /* @@ -224,34 +229,22 @@ static gboolean on_msgwin_button_press(GtkWidget *widget, GdkEventButton *event, if (!gtk_tree_path_compare(pressed_path, selected_path)) { - gboolean have_source; + frame *f; GtkTreeIter iter; gtk_tree_model_get_iter ( model, &iter, pressed_path); - gtk_tree_model_get ( - model, - &iter, - S_HAVE_SOURCE, &have_source, - -1); + gtk_tree_model_get (model, &iter, S_FRAME, &f, -1); /* check if file name is not empty and we have source files for the frame */ - if (have_source) + if (f->have_source) { - gchar *file; - gint line; - gtk_tree_model_get ( - model, - &iter, - S_FILEPATH, &file, - S_LINE, &line, - -1); - move_to_line(file, line); - - g_free(file); + move_to_line(f->file, f->line); } + + frame_unref(f); } g_list_foreach (rows, (GFunc) gtk_tree_path_free, NULL); @@ -283,7 +276,7 @@ static void on_selection_changed(GtkTreeSelection *treeselection, gpointer user_ if (2 == gtk_tree_path_get_depth(path)) { - gboolean have_source; + frame *f; GtkTreeIter iter; gtk_tree_model_get_iter ( @@ -293,30 +286,59 @@ static void on_selection_changed(GtkTreeSelection *treeselection, gpointer user_ gtk_tree_model_get ( gtk_tree_view_get_model(GTK_TREE_VIEW(tree)), &iter, - S_HAVE_SOURCE, &have_source, + S_FRAME, &f, -1); /* check if file name is not empty and we have source files for the frame */ - if (have_source) + if (f->have_source) { - gchar *file; - gint line; - gtk_tree_model_get ( - model, - &iter, - S_FILEPATH, &file, - S_LINE, &line, - -1); - - move_to_line(file, line); - g_free(file); + move_to_line(f->file, f->line); } + frame_unref(f); } g_list_foreach (rows, (GFunc)gtk_tree_path_free, NULL); g_list_free(rows); } +static void on_render_function (GtkTreeViewColumn *tree_column, GtkCellRenderer *cell, + GtkTreeModel *tree_model, GtkTreeIter *iter, gpointer data) +{ + frame *f; + + gtk_tree_model_get (tree_model, iter, S_FRAME, &f, -1); + if (! f) + g_object_set (cell, "text", "", NULL); + else + { + g_object_set (cell, "text", f->function, NULL); + frame_unref (f); + } +} + +static void on_render_address (GtkTreeViewColumn *tree_column, GtkCellRenderer *cell, + GtkTreeModel *tree_model, GtkTreeIter *iter, gpointer data) +{ + frame *f; + + gtk_tree_model_get (tree_model, iter, S_FRAME, &f, -1); + if (f) + { + g_object_set (cell, "text", f->address, NULL); + frame_unref (f); + } + else + { + gint thread_id; + gchar *thread_label; + + gtk_tree_model_get (model, iter, S_THREAD_ID, &thread_id, -1); + thread_label = g_strdup_printf(_("Thread %i"), thread_id); + g_object_set (cell, "text", thread_label, NULL); + g_free(thread_label); + } +} + /* * inits stack trace tree */ @@ -331,14 +353,9 @@ GtkWidget* stree_init(move_to_line_cb ml, select_frame_cb sf) /* create tree view */ store = gtk_tree_store_new ( S_N_COLUMNS, - G_TYPE_STRING, - G_TYPE_STRING, - G_TYPE_STRING, - G_TYPE_INT, - G_TYPE_STRING, - G_TYPE_INT, - G_TYPE_INT, - G_TYPE_INT); + STREE_TYPE_FRAME, /* frame */ + G_TYPE_INT /* thread ID */, + G_TYPE_BOOLEAN /* active */); model = GTK_TREE_MODEL(store); tree = gtk_tree_view_new_with_model (GTK_TREE_MODEL(store)); @@ -359,7 +376,7 @@ GtkWidget* stree_init(move_to_line_cb ml, select_frame_cb sf) /* creating columns */ /* address */ - column = gtk_tree_view_column_new(); + column_address = column = gtk_tree_view_column_new(); gtk_tree_view_column_set_title(column, _("Address")); renderer_arrow = cell_renderer_frame_icon_new (); @@ -372,33 +389,33 @@ GtkWidget* stree_init(move_to_line_cb ml, select_frame_cb sf) renderer = gtk_cell_renderer_text_new (); gtk_tree_view_column_pack_start(column, renderer, TRUE); - gtk_tree_view_column_set_attributes(column, renderer, "text", S_ADRESS, NULL); + gtk_tree_view_column_set_cell_data_func(column, renderer, on_render_address, NULL, NULL); gtk_tree_view_append_column (GTK_TREE_VIEW (tree), column); /* function */ renderer = gtk_cell_renderer_text_new (); - column = gtk_tree_view_column_new_with_attributes (_("Function"), renderer, "text", S_FUNCTION, NULL); + column = gtk_tree_view_column_new_with_attributes (_("Function"), renderer, NULL); + gtk_tree_view_column_set_cell_data_func(column, renderer, on_render_function, NULL, NULL); gtk_tree_view_column_set_resizable (column, TRUE); gtk_tree_view_append_column (GTK_TREE_VIEW (tree), column); /* file */ renderer = gtk_cell_renderer_text_new (); - column = gtk_tree_view_column_new_with_attributes (_("File"), renderer, NULL); + column_filepath = column = gtk_tree_view_column_new_with_attributes (_("File"), renderer, NULL); gtk_tree_view_column_set_resizable (column, TRUE); gtk_tree_view_append_column (GTK_TREE_VIEW (tree), column); gtk_tree_view_column_set_cell_data_func(column, renderer, on_render_filename, NULL, NULL); /* line */ renderer = gtk_cell_renderer_text_new (); - column = gtk_tree_view_column_new_with_attributes (_("Line"), renderer, "text", S_LINE, NULL); + column = gtk_tree_view_column_new_with_attributes (_("Line"), renderer, NULL); gtk_tree_view_column_set_cell_data_func(column, renderer, on_render_line, NULL, NULL); gtk_tree_view_column_set_resizable (column, TRUE); gtk_tree_view_append_column (GTK_TREE_VIEW (tree), column); /* Last invisible column */ - renderer = gtk_cell_renderer_text_new (); - column = gtk_tree_view_column_new_with_attributes ("", renderer, "text", S_LAST_VISIBLE, NULL); + column = gtk_tree_view_column_new (); gtk_tree_view_append_column (GTK_TREE_VIEW (tree), column); /* create threads hash table */ @@ -426,13 +443,7 @@ void stree_add(frame *f) gtk_tree_store_insert_before(store, &frame_iter, &thread_iter, 0); - gtk_tree_store_set (store, &frame_iter, - S_ADRESS, f->address, - S_FUNCTION, f->function, - S_FILEPATH, f->file, - S_LINE, f->line, - S_HAVE_SOURCE, f->have_source, - -1); + gtk_tree_store_set (store, &frame_iter, S_FRAME, f, -1); } /* @@ -496,7 +507,6 @@ void stree_destroy(void) */ void stree_add_thread(int thread_id) { - gchar *thread_label; GtkTreePath *tpath; GtkTreeRowReference *reference; GtkTreeIter thread_iter, new_thread_iter; @@ -530,12 +540,10 @@ void stree_add_thread(int thread_id) gtk_tree_store_append (store, &new_thread_iter, NULL); } - thread_label = g_strdup_printf(_("Thread %i"), thread_id); gtk_tree_store_set (store, &new_thread_iter, - S_ADRESS, thread_label, + S_FRAME, NULL, S_THREAD_ID, thread_id, -1); - g_free(thread_label); tpath = gtk_tree_model_get_path(model, &new_thread_iter); reference = gtk_tree_row_reference_new(model, tpath); -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] 132116: debugger: Fix missing sentinel in gtk_tree_model_get() call
by Colomban Wendling 05 Feb '16

05 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Fri, 05 Feb 2016 01:42:21 UTC Commit: 1321161e0944d154674c45820f9ffb61d8f17f82 https://github.com/geany/geany-plugins/commit/1321161e0944d154674c45820f9ff… Log Message: ----------- debugger: Fix missing sentinel in gtk_tree_model_get() call Modified Paths: -------------- debugger/src/stree.c Modified: debugger/src/stree.c 2 lines changed, 1 insertions(+), 1 deletions(-) =================================================================== @@ -507,7 +507,7 @@ void stree_add_thread(int thread_id) do { int existing_thread_id; - gtk_tree_model_get(model, &thread_iter, S_THREAD_ID, &existing_thread_id); + gtk_tree_model_get(model, &thread_iter, S_THREAD_ID, &existing_thread_id, -1); if (existing_thread_id > thread_id) { consecutive = &thread_iter; -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] 1ddf95: debugger: Speed up building several lists
by Colomban Wendling 05 Feb '16

05 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Fri, 05 Feb 2016 01:27:22 UTC Commit: 1ddf952d3a4c1998d18e788b901f0e72177ec337 https://github.com/geany/geany-plugins/commit/1ddf952d3a4c1998d18e788b901f0… Log Message: ----------- debugger: Speed up building several lists Prepend elements to GLists and reverse them afterward when possible, as GLists have very bad append performances as it walks the entire list to find the end, where to insert the new element. Modified Paths: -------------- debugger/src/breakpoints.c debugger/src/dbm_gdb.c debugger/src/debug.c debugger/src/envtree.c debugger/src/watch_model.c Modified: debugger/src/breakpoints.c 6 lines changed, 3 insertions(+), 3 deletions(-) =================================================================== @@ -70,7 +70,7 @@ static void hash_table_foreach_call_function(gpointer key, gpointer value, gpoin static gboolean tree_foreach_add_to_list(gpointer key, gpointer value, gpointer data) { GList **list = (GList**)data; - *list = g_list_append(*list, value); + *list = g_list_prepend(*list, value); return FALSE; } @@ -675,7 +675,7 @@ GList* breaks_get_for_document(const char* file) { g_tree_foreach(tree, tree_foreach_add_to_list, &breaks); } - return breaks; + return g_list_reverse(breaks); } /* @@ -702,5 +702,5 @@ GList* breaks_get_all(void) { GList *breaks = NULL; g_hash_table_foreach(files, hash_table_foreach_add_to_list, &breaks); - return breaks; + return g_list_reverse(breaks); } Modified: debugger/src/dbm_gdb.c 14 lines changed, 8 insertions(+), 6 deletions(-) =================================================================== @@ -213,10 +213,10 @@ static GList* read_until_prompt(void) break; line[terminator] = '\0'; - lines = g_list_append (lines, line); + lines = g_list_prepend (lines, line); } - return lines; + return g_list_reverse(lines); } /* @@ -1129,11 +1129,11 @@ static GList* get_stack(void) /* line */ f->line = line ? atoi(line) : 0; - stack = g_list_append(stack, f); + stack = g_list_prepend(stack, f); } gdb_mi_record_free(record); - return stack; + return g_list_reverse(stack); } /* @@ -1293,8 +1293,9 @@ static void update_watches(void) var->evaluated = name != NULL; /* add to updating list */ - updating = g_list_append(updating, var); + updating = g_list_prepend(updating, var); } + updating = g_list_reverse(updating); /* update watches */ get_variables(updating); @@ -1465,11 +1466,12 @@ static GList* get_children (gchar* path) var = variable_new2(name, internal, VT_CHILD); var->evaluated = TRUE; - children = g_list_append(children, var); + children = g_list_prepend(children, var); } } gdb_mi_record_free(record); + children = g_list_reverse(children); get_variables(children); return children; Modified: debugger/src/debug.c 8 lines changed, 4 insertions(+), 4 deletions(-) =================================================================== @@ -418,13 +418,13 @@ static gboolean on_watch_key_pressed_callback(GtkWidget *widget, GdkEvent *even /* add path reference if it's not an empty row*/ if (gtk_tree_path_compare(path, empty_path)) - references = g_list_append(references, gtk_tree_row_reference_new(wmodel, path)); + references = g_list_prepend(references, gtk_tree_row_reference_new(wmodel, path)); iter = iter->next; } /* iterate through references and remove */ - iter = references; + iter = g_list_reverse(references); while (iter) { GtkTreeRowReference *reference = (GtkTreeRowReference*)iter->data; @@ -1126,11 +1126,11 @@ GList* debug_get_modules(void) module_description *desc = modules; while (desc->title) { - mods = g_list_append(mods, (gpointer)desc->title); + mods = g_list_prepend(mods, (gpointer)desc->title); desc++; } - return mods; + return g_list_reverse(mods); } /* Modified: debugger/src/envtree.c 4 lines changed, 2 insertions(+), 2 deletions(-) =================================================================== @@ -135,7 +135,7 @@ static void delete_selected_rows(void) } if (gtk_tree_path_compare(path, empty_path)) - references = g_list_append(references, gtk_tree_row_reference_new(model, path)); + references = g_list_prepend(references, gtk_tree_row_reference_new(model, path)); iter = iter->next; } @@ -145,7 +145,7 @@ static void delete_selected_rows(void) if (!reference_to_select) reference_to_select = gtk_tree_row_reference_copy (empty_row); - iter = references; + iter = g_list_reverse(references); while (iter) { GtkTreeIter titer; Modified: debugger/src/watch_model.c 4 lines changed, 2 insertions(+), 2 deletions(-) =================================================================== @@ -476,9 +476,9 @@ GList *get_root_items(GtkTreeView *tree) -1); if (strlen(name)) - names = g_list_append(names, name); + names = g_list_prepend(names, name); } while (gtk_tree_model_iter_next(model, &child)); - return names; + return g_list_reverse(names); } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany-plugins] 575791: debugger: Fix tooltips in the Call Stack
by Colomban Wendling 05 Feb '16

05 Feb '16

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Fri, 05 Feb 2016 01:17:40 UTC Commit: 575791a862f93c4eceec9825e9e7ffce5cc69cb4 https://github.com/geany/geany-plugins/commit/575791a862f93c4eceec9825e9e7f… Log Message: ----------- debugger: Fix tooltips in the Call Stack Fix a funny typo leading to incorrect restriction of tooltip display. Modified Paths: -------------- debugger/src/stree.c Modified: debugger/src/stree.c 2 lines changed, 1 insertions(+), 1 deletions(-) =================================================================== @@ -135,7 +135,7 @@ static gboolean on_query_tooltip(GtkWidget *widget, gint x, gint y, gboolean key g_free(path); } - else if (column == gtk_tree_view_get_column(GTK_TREE_VIEW(widget), S_ADRESS && bx >= start_pos && bx < start_pos + width)) + else if (column == gtk_tree_view_get_column(GTK_TREE_VIEW(widget), S_ADRESS) && bx >= start_pos && bx < start_pos + width) { gtk_tooltip_set_text(tooltip, gtk_tree_path_get_indices(tpath)[1] == active_frame_index ? _("Active frame") : _("Click an arrow to switch to a frame")); gtk_tree_view_set_tooltip_row(GTK_TREE_VIEW(widget), tooltip, tpath); -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

Plugins-Commits February 2016