Branch: refs/heads/master
Author: Jiří Techet <techet(a)gmail.com>
Committer: Jiří Techet <techet(a)gmail.com>
Date: Wed, 15 Oct 2014 14:01:22 UTC
Commit: bfe78bc06198df06048b94569b059b0b3b4383c2
https://github.com/geany/geany-plugins/commit/bfe78bc06198df06048b94569b059…
Log Message:
-----------
geanyctags: use g_unlink() instead of removing files by windows cmdline "del"
Modified Paths:
--------------
geanyctags/src/geanyctags.c
Modified: geanyctags/src/geanyctags.c
7 lines changed, 1 insertions(+), 6 deletions(-)
===================================================================
@@ -209,12 +209,7 @@ on_generate_tags(GtkMenuItem *menuitem, gpointer user_data)
/* Unfortunately, there's a bug in ctags - when run with -R, the first line is
* empty, ctags doesn't recognize the tags file as a valid ctags file and
* refuses to overwrite it. Therefore, we need to delete the tags file manually. */
- gchar **argv = g_new0(gchar *, 2);
- argv[0] = g_strconcat("del ", tag_filename, NULL);
- argv[1] = NULL;
- utils_spawn_sync(prj->base_path, argv, NULL, G_SPAWN_SEARCH_PATH,
- NULL, NULL, NULL, NULL, NULL, NULL));
- g_strfreev(argv);
+ g_unlink(tag_filename);
cmd = g_strconcat("ctags.exe -R --totals --fields=fKsSt --extra=-fq --c-kinds=+p --sort=foldcase --excmd=number -f ",
tag_filename, NULL);
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).
Branch: refs/heads/master
Author: Colomban Wendling <ban(a)herbesfolles.org>
Committer: Colomban Wendling <ban(a)herbesfolles.org>
Date: Wed, 15 Oct 2014 12:52:49 UTC
Commit: 953532b1d1eb2e6ba1e2fb0e2b43eb166fe521d6
https://github.com/geany/geany-plugins/commit/953532b1d1eb2e6ba1e2fb0e2b43e…
Log Message:
-----------
multiterm: Fix building with recent Vala versions
Vala doesn't allow dynamic code as global variable initializers
anymore, so move the dynamic initialization inside plugin_init().
Interestingly, if this actually used to work is only because the
initialization wasn't actually dynamic in C, as a NULL GList is a
valid one and that's what it was initialized to.
Modified Paths:
--------------
multiterm/src/plugin.vala
Modified: multiterm/src/plugin.vala
5 lines changed, 4 insertions(+), 1 deletions(-)
===================================================================
@@ -28,7 +28,7 @@ public Data geany_data;
public Functions geany_functions;
/* Widgets to clean up when the plugin is unloaded */
-private List<Widget> toplevel_widgets = new List<Widget>();
+private List<Widget> toplevel_widgets = null;
/* Geany calls this to determine min. required API/ABI version */
public int plugin_version_check(int abi_version)
@@ -57,6 +57,8 @@ public void plugin_init(Geany.Data data)
* unregistering and re-registering new types */
geany_plugin.module_make_resident();
+ toplevel_widgets = new List<Widget>();
+
/* Initialize plugin's configuration directory/file */
config_dir = Path.build_filename(geany_data.app.config_dir, "plugins", "multiterm");
config_file = Path.build_filename(config_dir, "multiterm.conf");
@@ -107,4 +109,5 @@ public void plugin_cleanup ()
{
foreach (Widget wid in toplevel_widgets)
wid.destroy();
+ toplevel_widgets = null;
}
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).
Branch: refs/heads/master
Author: Jiří Techet <techet(a)gmail.com>
Committer: Jiří Techet <techet(a)gmail.com>
Date: Wed, 15 Oct 2014 08:39:37 UTC
Commit: 08fd8ded5543abf92357e0061d14452925be0e35
https://github.com/geany/geany-plugins/commit/08fd8ded5543abf92357e0061d144…
Log Message:
-----------
gproject: replace g_return_if_fail() with normal if check
This can legally happen on plugin unload/load.
Modified Paths:
--------------
gproject/src/gproject-project.c
Modified: gproject/src/gproject-project.c
3 lines changed, 2 insertions(+), 1 deletions(-)
===================================================================
@@ -466,7 +466,8 @@ gint gprj_project_add_properties_tab(GtkWidget *notebook)
void gprj_project_close(void)
{
- g_return_if_fail(g_prj);
+ if (!g_prj)
+ return; /* can happen on plugin reload */
if (g_prj->generate_tags)
g_hash_table_foreach(g_prj->file_tag_table, (GHFunc)workspace_remove_tag, NULL);
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).