Revision: 2216
http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=2216&view=rev
Author: frlan
Date: 2011-09-25 20:08:05 +0000 (Sun, 25 Sep 2011)
Log Message:
-----------
GeanySendMail: Don't free address variable in case of none address-dialog was shown.
Modified Paths:
--------------
trunk/geany-plugins/geanysendmail/ChangeLog
trunk/geany-plugins/geanysendmail/src/geanysendmail.c
Modified: trunk/geany-plugins/geanysendmail/ChangeLog
===================================================================
--- trunk/geany-plugins/geanysendmail/ChangeLog 2011-09-25 20:07:43 UTC (rev 2215)
+++ trunk/geany-plugins/geanysendmail/ChangeLog 2011-09-25 20:08:05 UTC (rev 2216)
@@ -2,6 +2,7 @@
* Adding a workaround for a weird issue in connection with
utils_string_replace_all().
+ * Don't free address variable in case of none address-dialog was shown.
Modified: trunk/geany-plugins/geanysendmail/src/geanysendmail.c
===================================================================
--- trunk/geany-plugins/geanysendmail/src/geanysendmail.c 2011-09-25 20:07:43 UTC (rev 2215)
+++ trunk/geany-plugins/geanysendmail/src/geanysendmail.c 2011-09-25 20:08:05 UTC (rev 2216)
@@ -149,7 +149,6 @@
{
/* Removes %r if option was not activ but was included into command */
utils_string_replace_all(cmd_str, "%r", "");
- g_free(address);
}
utils_string_replace_all(cmd_str, "%b", g_path_get_basename(locale_filename));
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 2215
http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=2215&view=rev
Author: frlan
Date: 2011-09-25 20:07:43 +0000 (Sun, 25 Sep 2011)
Log Message:
-----------
GeanySendMail: A more clean workaround
Modified Paths:
--------------
trunk/geany-plugins/geanysendmail/src/geanysendmail.c
Modified: trunk/geany-plugins/geanysendmail/src/geanysendmail.c
===================================================================
--- trunk/geany-plugins/geanysendmail/src/geanysendmail.c 2011-09-25 16:59:59 UTC (rev 2214)
+++ trunk/geany-plugins/geanysendmail/src/geanysendmail.c 2011-09-25 20:07:43 UTC (rev 2215)
@@ -148,11 +148,8 @@
else
{
/* Removes %r if option was not activ but was included into command */
- gchar *tmp_fix;
- tmp_fix = g_strdup("");
- utils_string_replace_all(cmd_str, "%r", tmp_fix);
+ utils_string_replace_all(cmd_str, "%r", "");
g_free(address);
- g_free(tmp_fix);
}
utils_string_replace_all(cmd_str, "%b", g_path_get_basename(locale_filename));
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 2211
http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=2211&view=rev
Author: frlan
Date: 2011-09-24 22:28:32 +0000 (Sat, 24 Sep 2011)
Log Message:
-----------
Addming some minor requirements for documentation to HACKING file
Modified Paths:
--------------
trunk/geany-plugins/HACKING
Modified: trunk/geany-plugins/HACKING
===================================================================
--- trunk/geany-plugins/HACKING 2011-09-21 18:30:27 UTC (rev 2210)
+++ trunk/geany-plugins/HACKING 2011-09-24 22:28:32 UTC (rev 2211)
@@ -11,11 +11,13 @@
This file contains some useful information for any plugin developer, and
especially for new plugin developers.
+
Building your plugin
--------------------
You should first read either `README` or `README.waf` depending on whether
you want to use Autotools or Waf to build the plugins.
+
Autotools Build System
^^^^^^^^^^^^^^^^^^^^^^
The Autotools build system automatically enables some code checking
@@ -33,3 +35,37 @@
necessarily and always right -- though they try.
If you think they reports wrong problems, please file a report on the
appropriate place (either the mailing lists or the geany-plugins bug tracker).
+
+
+Documentation
+-------------
+
+README
+^^^^^^
+Inside each plugin folder, that should be a README located.
+
+
+Something about the markup being used
+#####################################
+
+The README is intended to be written in
+`Restructured Text <http://sphinx.pocoo.org/rest.html>`_
+(as this document is) and therefor should be working e.g. with running
+rst2html or similar tools. The reason for is, that these information are
+getting used by generating content of http://plugins.geany.org.
+
+
+Content that shall be in
+########################
+
+The documentation should include a minimum on content. This means a
+detailed description on features offered by the plugins and usage of
+this features. But also it should include some basic information
+which is making it easier for the user to get in contact or to find
+help in case of any issues.
+
+* author(s) of plugin and its mail addresses
+* web pages, if there are any beside of http://plugins.geany.org
+* know issues
+* bug tracker
+* dependencies
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 2210
http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=2210&view=rev
Author: colombanw
Date: 2011-09-21 18:30:27 +0000 (Wed, 21 Sep 2011)
Log Message:
-----------
PrettyPrinter: define HAVE_GLIB when building with Waf too
Modified Paths:
--------------
trunk/geany-plugins/pretty-printer/wscript_build
Modified: trunk/geany-plugins/pretty-printer/wscript_build
===================================================================
--- trunk/geany-plugins/pretty-printer/wscript_build 2011-09-21 16:57:15 UTC (rev 2209)
+++ trunk/geany-plugins/pretty-printer/wscript_build 2011-09-21 18:30:27 UTC (rev 2210)
@@ -26,5 +26,6 @@
name = 'Pretty-Printer'
includes = ['pretty-printer/src']
libraries = ['LIBXML_2_0']
+defines = ['HAVE_GLIB=1']
-build_plugin(bld, name, includes=includes, libraries=libraries)
+build_plugin(bld, name, includes=includes, libraries=libraries, defines=defines)
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 2209
http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=2209&view=rev
Author: colombanw
Date: 2011-09-21 16:57:15 +0000 (Wed, 21 Sep 2011)
Log Message:
-----------
PrettyPrinter: convert PP_ERROR() to a function
Convert PP_ERROR() to a function because it cannot be implemented in
a portable way as a macro using ISO C99.
Modified Paths:
--------------
trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c
Modified: trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c
===================================================================
--- trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c 2011-09-21 16:56:57 UTC (rev 2208)
+++ trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c 2011-09-21 16:57:15 UTC (rev 2209)
@@ -20,6 +20,9 @@
//======================= FUNCTIONS ====================================================================
+//error reporting functions
+static void PP_ERROR(const char* fmt, ...) G_GNUC_PRINTF(1,2); //prints an error message
+
//xml pretty printing functions
static void putCharInBuffer(char charToAdd); //put a char into the new char buffer
static void putCharsInBuffer(const char* charsToAdd); //put the chars into the new char buffer
@@ -73,7 +76,15 @@
//============================================ GENERAL FUNCTIONS =======================================
-#define PP_ERROR(format, ...) fprintf(stderr, format "\n", ##__VA_ARGS__);
+static void PP_ERROR(const char* fmt, ...)
+{
+ va_list va;
+
+ va_start(va, fmt);
+ vfprintf(stderr, fmt, va);
+ putc('\n', stderr);
+ va_end(va);
+}
int processXMLPrettyPrinting(char** buffer, int* length, PrettyPrintingOptions* ppOptions)
{
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 2208
http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=2208&view=rev
Author: colombanw
Date: 2011-09-21 16:56:57 +0000 (Wed, 21 Sep 2011)
Log Message:
-----------
PrettyPrinter: mark printError() as taking printf-style varargs
This allows some compilers (i.e. GCC) to check the argument format
and types.
Modified Paths:
--------------
trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c
Modified: trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c
===================================================================
--- trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c 2011-09-21 16:56:38 UTC (rev 2207)
+++ trunk/geany-plugins/pretty-printer/src/PrettyPrinter.c 2011-09-21 16:56:57 UTC (rev 2208)
@@ -50,7 +50,7 @@
static void processDoctypeElement(void); //process a DOCTYPE ELEMENT node
//debug function
-static void printError(const char *msg, ...); //just print a message like the printf method
+static void printError(const char *msg, ...) G_GNUC_PRINTF(1,2); //just print a message like the printf method
static void printDebugStatus(void); //just print some variables into the console for debugging
//============================================ PRIVATE PROPERTIES ======================================
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.