This is based on a patch. It builds on gtk3 as well as gtk2 but not thoroughly tested. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/352
-- Commit Summary --
* Macro plugin for both gtk2 and gtk3 [Needs Testing]
-- File Changes --
M build/geanymacro.m4 (2) M geanymacro/src/geanymacro.c (67)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/352.patch https://github.com/geany/geany-plugins/pull/352.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352
@@ -1387,21 +1386,26 @@ static void EditSearchOptions(GtkTreeModel *model,GtkTreeIter *iter) /* create dialog box */ dialog=gtk_dialog_new_with_buttons(_("Search Options:"), GTK_WINDOW(geany->main_widgets->window),
GTK_DIALOG_DESTROY_WITH_PARENT,NULL);
GTK_DIALOG_DESTROY_WITH_PARENT,+_("Ok"),
Mnemonic should not be removed (unless actually wanted)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352/files#r53330667
@@ -1387,21 +1386,26 @@ static void EditSearchOptions(GtkTreeModel *model,GtkTreeIter *iter) /* create dialog box */ dialog=gtk_dialog_new_with_buttons(_("Search Options:"), GTK_WINDOW(geany->main_widgets->window),
GTK_DIALOG_DESTROY_WITH_PARENT,NULL);
GTK_DIALOG_DESTROY_WITH_PARENT,+_("Ok"),
GTK_RESPONSE_OK,_("Cancel"),
ditto
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352/files#r53330682
@@ -1733,9 +1736,12 @@ static void EditMacroElements(Macro *m)
/* create dialog box */ cTitle=g_strdup_printf(_("Edit: %s"),m->name);
- dialog=gtk_dialog_new_with_buttons(cTitle,GTK_WINDOW(geany->main_widgets->window),
GTK_DIALOG_DESTROY_WITH_PARENT,NULL);
- dialog=gtk_dialog_new();
- //_with_buttons(cTitle,GTK_WINDOW(geany->main_widgets->window),
//GTK_DIALOG_DESTROY_WITH_PARENT,NULL);- gtk_window_set_title(GTK_WINDOW(dialog), cTitle);
- gtk_window_set_transient_for(GTK_WINDOW(dialog), GTK_WINDOW(geany->main_widgets->window));
- gtk_window_set_destroy_with_parent(GTK_WINDOW(dialog), TRUE);
what was the problem with the `_with_buttons()` call, but with 0 buttons?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352/files#r53330997
Indentation has some problems, and some code should be dropped rather than commented out.
Also, did you check how the widgets expand? `gtk_conatiner_add()` changed behavior to that regard in GTK3, where it doesn't expand by default.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352#issuecomment-185783392
@b4n I guess I did unnecessary changes regarding `gtk_dialog`. Also, I have not tested it thoroughly
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352#issuecomment-186218012
@sagarchalise pushed 1 commit.
433d2b1 upstream compatibility
--- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/352/files/5876cb1d5301182a1c9809...
Hum, according to GitHub there are no changes. And apparently the version in master already supports GTK3 just fine, because of #410
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352#issuecomment-226954857
Closed #352.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352#event-730314634
This has already been implemented by #410
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/352#issuecomment-234238308
github-comments@lists.geany.org