Removed obsolete GIO check. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/720
-- Commit Summary --
* treebrowser: removed HAVE_GIO checks
-- File Changes --
M build/treebrowser.m4 (6) M treebrowser/src/treebrowser.c (6)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/720.patch https://github.com/geany/geany-plugins/pull/720.diff
b4n commented on this pull request.
@@ -208,7 +206,7 @@ utils_pixbuf_from_stock(const gchar *stock_id)
static GdkPixbuf * utils_pixbuf_from_path(gchar *path) { -#if defined(HAVE_GIO) && GTK_CHECK_VERSION(2, 14, 0) +#if GTK_CHECK_VERSION(2, 14, 0)
The GTK check is also mostly irrelevant given how old GTK 2.24 is, and that Geany is depending on 2.24 for a long time now. But that's outside of the scope of this PR.
b4n approved this pull request.
LGBI
Merged #720.
FWIW, this check was more or less always obsolete, GIO is in GLib, and if GTK exposes API using its types it ought to be present…
But `libgio` is a separate library, maybe that was really what should have been tested? Sure on Linux its in the glib package so it will allways be there, but maybe not on Windows or OSX (at least before msys).
It's pointless for plugins to check for GIO since GTK+ and Geany both use and require the library.
github-comments@lists.geany.org