I noticed that the integration library isn't used when using meson because it's not added to `deps`.
@kugel- Does the change look good to you? You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3301
-- Commit Summary --
* Fix gtk-mac-integration not being used when using meson
-- File Changes --
M meson.build (1)
-- Patch Links --
https://github.com/geany/geany/pull/3301.patch https://github.com/geany/geany/pull/3301.diff
@kugel- Ping.
Alright. Although it means plugins would also link against gtk-mac-integration, which is probably unecessary.
@kugel- approved this pull request.
Although it means plugins would also link against gtk-mac-integration, which is probably unecessary.
But does it happen when `deps_for_pc` doesn't contain `mac_integration`? (I added it only to `deps` but not to `deps_for_pc `)
deps_for_pc is only used for the pkgconfig file. deps is used for everything, including geany binary, libgeany and plugins.
@techee pushed 2 commits.
4ed2f5c6076fb8fd4fde41ce66f4d824207714e4 Fix gtk-mac-integration not being used when using meson e90f5a1801f4ebccb3c5bfde6556f24249ceae2e Rename mac_integration to dep_mac_integration to match other dependencies
OK, I changed the patch to avoid the unnecessary linking - does it still look OK?
yea
@kugel- approved this pull request.
Merged #3301 into master.
github-comments@lists.geany.org