Try and remove special casing of built-in tags files, by making them normal tags files named appropriately and following the format (*html_entities.tags* didn't).
This might require a little further testing, but it seems to work just as expected, and removes the startup warnings about those tags files' name (introduced by 3640b3bc4461f302cc2375e4998c58f7729493eb AFAICT): ``` Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/html_entities.tags'. Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/pascal.tags'. Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/c99.tags'. Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/python.tags'. Geany-INFO: Unknown filetype for file '/usr/local/share/geany/tags/php.tags'. ``` You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1014
-- Commit Summary --
* Make html_entities.tags a real tags file * Don't special-case tags files distributed with Geany
-- File Changes --
M data/Makefile.am (10) R data/tags/entities.html.tags (3) R data/tags/std.pas.tags (0) R data/tags/std.php.tags (0) R data/tags/std.py.tags (0) R data/tags/std99.c.tags (0) M src/editor.c (48) M src/symbols.c (93) M src/symbols.h (2) M src/utils.c (19) M src/utils.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/1014.patch https://github.com/geany/geany/pull/1014.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1014
LGBI +10-109, moving in the right direction :)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1014#issuecomment-215605845
LGTM, great! `make distcheck` still works, however this is no surprise if @b4n is doing such changes :). I quickly tested auto completion of the included tags files and I couldn't find any breakage, the `Unknown filetype` warnings are also gone.
And I like the removal of all the special code, very nice.
What about merging this to test it more intensively by every day use?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1014#issuecomment-219211560
Merged #1014.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1014#event-660996035
github-comments@lists.geany.org