Fixes #2261. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2263
-- Commit Summary --
* configure: check for realpath function now MSYS2 has it
-- File Changes --
M configure.ac (2) M src/tagmanager/tm_source_file.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/2263.patch https://github.com/geany/geany/pull/2263.diff
codebrainz commented on this pull request.
@@ -84,7 +84,7 @@ static int get_path_max(const char *path)
}
-#ifdef G_OS_WIN32 +#if defined(G_OS_WIN32) && !defined(HAVE_REALPATH)
You could probably drop the `G_OS_WIN32` part altogether, but this is probably safer for now.
codebrainz approved this pull request.
Looks OK by inspection.
ntrel commented on this pull request.
@@ -84,7 +84,7 @@ static int get_path_max(const char *path)
}
-#ifdef G_OS_WIN32 +#if defined(G_OS_WIN32) && !defined(HAVE_REALPATH)
Well, the implementation only compiles on Windows.
Is this still relevant? Looking at the conversation in #2261 it's kind of unclear. However, this looks good anyhow.
b4n approved this pull request.
Looks good and safe
Should probably merge this for 1.36?
Two approvals is enough for me.
Merged #2263 into master.
github-comments@lists.geany.org