Update the ctags to minimal version required for the Kotlin parser to work. No changes to the geany sources were necessary.
This a prerequisite to https://github.com/dolik-rce/geany/pull/1, as suggested by @elextr in https://github.com/geany/geany/pull/2778#issuecomment-864518340. Unfortunately, that PR can't be created here directly, since it compares two branches in my fork, but I will move it to this repository as soon as this PR is accepted or when someone with commit rights to geany repository pulls in this branch.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2830
-- Commit Summary --
* update ctags to version p5.9.20210411.0
-- File Changes --
M ctags/main/dependency.c (13) M ctags/main/entry.c (15) M ctags/main/entry.h (9) M ctags/main/error.c (8) M ctags/main/field.c (58) M ctags/main/field.h (3) M ctags/main/field_p.h (3) M ctags/main/fmt.c (4) M ctags/main/htable.c (94) M ctags/main/htable.h (23) M ctags/main/lregex.c (25) M ctags/main/lregex_p.h (2) M ctags/main/options.c (644) M ctags/main/options.h (1) M ctags/main/options_p.h (1) M ctags/main/parse.c (106) M ctags/main/parse.h (3) M ctags/main/parse_p.h (4) M ctags/main/parsers_p.h (14) M ctags/main/ptag.c (10) M ctags/main/ptag_p.h (7) M ctags/main/ptrarray.c (69) M ctags/main/ptrarray.h (9) M ctags/main/read.c (24) M ctags/main/read_p.h (4) M ctags/main/repoinfo.h (2) M ctags/main/routines.c (1) M ctags/main/routines.h (3) M ctags/main/routines_p.h (3) M ctags/main/subparser.h (2) M ctags/main/tokeninfo.c (4) M ctags/main/tokeninfo.h (8) M ctags/main/writer-ctags.c (55) M ctags/main/writer-json.c (6) M ctags/main/writer.c (8) M ctags/main/writer_p.h (4) M ctags/main/xtag.c (6) M ctags/main/xtag_p.h (12)
-- Patch Links --
https://github.com/geany/geany/pull/2830.patch https://github.com/geany/geany/pull/2830.diff
Unfortunately, that PR can't be created here directly
As much as we love to complain about Github, in this case I think its Linus' fault because Git doesn't have the capability of making a patch that depends on another until the first is merged.
@dolik-rce just to let you know this isn't forgotten, but we are trying to update the windows build architecture for GTK3 and then get a team together to make a 1.38 release. This will be merged as soon after that so it has time to be tested before the next release, but its better not to do it just before.
Ok, I'll wait. I very much appreciate the update, thank you.
Not sure how we are going to handle ctags updates in Geany - I'd suggest always updating to the latest ctags version after making a release and then, if possible, not touching it until the next release so it gets sufficient testing. If we do it this way, this pull request might be replaced by a newer ctags release (should be no problem, I can do it myself).
@techee yeah, that was the plan
@elextr: Now that 1.38 was released, is it the right time to update ctags? Should I create new PR to update to newest version?
@dolik-rce not forgotten, this was the next thing I planned to test after Scintilla 5 updates if nobody beat me to it. Due to Scintilla being central to Geany and this update being a jump of two major versions of Scintilla it is important to do first to allow maximum testing. Unfortunately there have been a couple of bugs in Scintilla which are addressed in 5.1.4 due out "in a couple of days" and should allow that to be merged.
Of course that doesn't stop anyone else from looking at this and/or updating to the latest ctags as discussed above.
Of course that doesn't stop anyone else from looking at this and/or updating to the latest ctags as discussed above.
Yeah, I was actually thinking about doing it myself (against the latest version of ctags) in case some problems pop up as I probably have most experience with this stuff. Will try to prepare a pull request today.
This has been superseded by #2984, closing.
Closed #2830.
github-comments@lists.geany.org