This PR causes window position and geometry to be unconditionally restored on startup, if present in the config file. `save_winpos` and `save_wingeom` still control whether *new* values are saved. So *already* saved settings will be preserved and applied. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2979
-- Commit Summary --
* <a href="https://github.com/geany/geany/pull/2979/commits/af502bb105af65aac5c1e796711ba786b4af0c67">Unconditionally restore saved position and geometry.</a>
-- File Changes --
M src/keyfile.c (7) M src/libmain.c (29)
-- Patch Links --
https://github.com/geany/geany/pull/2979.patch https://github.com/geany/geany/pull/2979.diff
Reason for edit of description, see [here](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-p...)
Reason for edit of description...
So I should have been writing "Fixes" all this time...
@xiota pushed 1 commit.
040e979210caf2262542d34a5425bbe7eda8d0ac Save position or geometry only when respective setting is set
Marked draft until the [ducks get lined up](https://dictionary.cambridge.org/dictionary/english/get-have-your-ducks-in-a...) in #2978
What ducks are you lining up?
Commit one says "Unconditionally restore saved position and geometry." which indicates this makes it impossible to _not_ load from the config.
Therefore it is removing removing a current capability. When changing current behaviour without giving users any say in it, it is important to ensure no functionality or user depends on the current behaviour. Just because we can't think of a use in 10 mins doesn't mean there is none.
This is one part of the whole muddle of sizing issues raised on #2978 so it should be addressed before rushing changes into the code.
before rushing changes into the code
I don't think marking it draft makes anything slower than they already are. The issues that have been raised over the years went nowhere, and the bugs have remained. My rediscovery of old issues has been because I was modifying and looking at the code.
@xiota pushed 1 commit.
d7a5a917abbc547f7ec8258797be624d40a3eb6a Calculate default sidebar/msgwin positions
This is working on my computer. It needs testing in other desktop environments, window man.
@xiota pushed 3 commits.
9bb60683998d71c32fb0bd051e9b940f22e9d801 Unconditionally restore saved position and geometry. 02d53b55b2b1a215295be208159ea531990c7022 Save position or geometry only when respective setting is set 0ee96c2d4c640e5371bd4db0e5c12bac5eb7bd6c Calculate default sidebar/msgwin positions
Closed #2979.
There may be a race-like condition that causes problems saving sidebar position when the window is maximized (#3070). Closing because there appears to be no interest, so not worth trying to fix.
github-comments@lists.geany.org