A good example of why is the changes to `ui_menu_add_document_items_sorted()`: the *format* should contain markup, but the placeholders should not (they will generally be mostly unknown text).
This however has one side effect on the API: [`ui_frame_new_with_alignment()`](https://www.geany.org/manual/reference/ui__utils_8h.html#a740aa567ff6b9e3829... first argument is passed as-is to `ui_label_new_bold()`, which itself is implemented using `ui_label_set_markup()`. The documentation of `ui_frame_new_with_alignment()` never suggested it supported markup (and none of the users I could fine did expect that), but it's a change in how the API works. IMO it's a bug fix (markup control character no longer break frame labels), but someone could see it as a feature removal (although it'd be somewhat dishonest as it never was advertized). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1174
-- Commit Summary --
* Escape format arguments passed to ui_label_set_markup()
-- File Changes --
M src/ui_utils.c (10)
-- Patch Links --
https://github.com/geany/geany/pull/1174.patch https://github.com/geany/geany/pull/1174.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1174
An additional change could be to deprecate those UI functions for future privatisation, recommending callers to instead use GTK+ directly. This bug is a good case for doing so :)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1174#issuecomment-238740760
Indeed, especially as there's no internal use of this function, and the only plugin I know using this is WebHelper which could easily do it on its own.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1174#issuecomment-238740938
LGBI
Subtle bug.
For the API, its not documented as supporting markup, so this is a bugfix for an undocumented capability that leaked.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1174#issuecomment-238741058
@b4n pushed 1 commit.
29bffe6 Deprecate ui_frame_new_with_alignment()
@codebrainz @elextr added a commit to deprecate `ui_frame_new_with_alignment()`.
Still LGBI
Merged #1174.
github-comments@lists.geany.org