Closes #3063. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3129
-- Commit Summary --
* Windows: Include "Prof-Gnome" GTK theme from geany-osx
-- File Changes --
M scripts/gtk-bundle-from-msys2.sh (23)
-- Patch Links --
https://github.com/geany/geany/pull/3129.patch https://github.com/geany/geany/pull/3129.diff
NAK from my side. Prof-Gnome might be an improvement over adwaita but it's still a bad default theme in my view. Everyone is free to chose a theme to their liking but the default theme should integrate into the target platform. I hate all those GTK apps on windows that look like alien.
That said, I don't use Windows, I only start Geany their for testing specific issues. So in the end of the day I won't block this becuase it doesn't affect *me*. I just don't agree with this PR and IMO it's the wrong direction for Geany on Windows.
I NAK'd the theme but I don't want to block any Adwaita-replacement so please go for it.
If this PR is going to get merged, I'd just suggest also applying the following patch on top of the theme.
https://github.com/geany/geany-osx/blob/master/prof_gnome_windows_changes.pa...
It changes text colors to #000000 instead of the slightly gray which is native for macOS, and also reduces the size of the status bar.
@eht16 pushed 1 commit.
704aaa1e622b4d41ecf8a53109b64aaa574a50c2 Add Prof-Gnome Windows specific patch
I NAK'd the theme but I don't want to block any Adwaita-replacement so please go for it.
Alright. https://www.geany.org/documentation/faq/#how-to-change-the-gtk-theme provides users with instructions on how to change the theme and there are also alternatives linked. I guess this is all an improvement over Adwaita, as you also say.
If this PR is going to get merged, I'd just suggest also applying the following patch on top of the theme.
I added the patch.
Will squash the commits before merge and merge tomorrow if nobody objects.
Merged #3129 into master.
github-comments@lists.geany.org