There doesn't seem to be much need for these and they look a little different from the rest of Geany (or a lot different when Windows uses the dark theme and Geany the light one). Before removing the native win32 file open dialogs, win32_message_dialog() was called from the native file dialog implementations so its presence was necessary but I think normal GTK dialogs will serve their purpose well.
This is just a suggestion, anyone please feel free to disagree :-)
Also, completely untested - I'll only be able to test it on Windows at the end of the week. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3903
-- Commit Summary --
* Drop win32_message_dialog()s
-- File Changes --
M src/dialogs.c (35) M src/win32.c (61) M src/win32.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/3903.patch https://github.com/geany/geany/pull/3903.diff
I'm all for it, but given I don't use Windows I don't think my vote is fair :slightly_smiling_face:
I'm all for it, but given I don't use Windows I don't think my vote is fair 🙂
Yeah, @eht16 is the official Windows guru and enthusiast :-)
I'm all for it, but given I don't use Windows I don't think my vote is fair 🙂
Yeah, @eht16 is the official Windows guru and enthusiast :-)
I'm neither of those but I'm aware you like to assign this to me :).
Anyway, tested on native Windows and works.
@eht16 approved this pull request.
One thing worth noting is the reversed order of buttons with GTK dialogs vs native Windows dialogs 
GTK dialogs have confirmation on the right, Windows on the left. Would this be a problem for Windows users?
Note that for other custom dialogs like search, replace, preferences, etc. Geany already uses the GTK order so this change would make things "consistently wrong" instead of "inconsistently correct".
Anyway, tested on native Windows and works.
I think the question is more "is it OK to drop it" :)
Anyway, tested on native Windows and works.
I think the question is more "is it OK to drop it" :)
The answer was given implicitly by testing it :). I don't remember why those dialogs did exist and I'm not even sure there was a distinct reason for. Most of the Geany Windows stuff I wrote almost two decades ago, was mostly out of curiosity whether it works, what can be done and what cannot. Since I don't use Windows (and did not use it for longer than Geany exists), I have no preference what dialogs to show. Dropping the native message dialogs removes code and reduces the risk of future breakages, so I think this is good.
GTK dialogs have confirmation on the right, Windows on the left. Would this be a problem for Windows users?
Note that for other custom dialogs like search, replace, preferences, etc. Geany already uses the GTK order so this change would make things "consistently wrong" instead of "inconsistently correct".
My two cents: being "consistently wrong" is probably better in this case for the benefit of better looking dialogs (especially if a dark or other custom GTK theme is used).
OK, let's give this one week of silence - if nobody complains in the meantime, I'll merge it.
Merged #3903 into master.
github-comments@lists.geany.org