Closes: https://github.com/geany/geany/issues/3435 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3436
-- Commit Summary --
* Meson: Don't compare objects of type bool with int
-- File Changes --
M meson.build (4)
-- Patch Links --
https://github.com/geany/geany/pull/3436.patch https://github.com/geany/geany/pull/3436.diff
@AntumDeluge pushed 1 commit.
13ed79b8433f087aef8edbe93176ef400f0ba79c Update workflow jobs to run on Ubuntu Jammy
@AntumDeluge don't think 22.04.2 is valid see [here](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-githu...)
@AntumDeluge don't think 22.04.2 is valid see [here](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-githu...)
Yes, you are correct. I switched it to `22.04` on my fork, but there is a new error. I'll fix the version for this PR anyway though.
@AntumDeluge pushed 1 commit.
de06f67feb2f2af66e31cbebc0efd75710cf7e6d Update workflow jobs to run on Ubuntu Jammy
Done.
I bet `HAVE_FNMATCH` is actually `#define`d as `1` and Meson is now honoring that rather than considering it boolean
Then why would `if cdata.get('HAVE_FNMATCH') == 1` fail in version `1.0`?
Maybe push the ` == 1` back to the PR to see if it works with 0.61, but yeah, dunno what is up with 1.0.
Yes, changing back works: https://github.com/AntumDeluge/geany/actions/runs/4507422669/jobs/7935187800
Perhaps this PR is all for naught. I'm going to see if I can get a response from Meson devs about 1.0.
@AntumDeluge pushed 1 commit.
d59c7bcd42d040f8f071742e0206a0d9e92d8c04 Meson: Add checks for compatibility with version 1.0
Okay, I changed the solution to add checks for Meson versions older than 1.0. Let me know if this is acceptable.
See my comment on the issue, but tl;dr version checks are totally irrelevant, meson is NOT changing the internal type produced by `cdata.set('HAVE_THING', 1)`.
Closed #3436.
github-comments@lists.geany.org