[geany/geany] Perhaps change fold/unfold to collapse/expand (#1793)

List overview All Threads

newer

older

[geany/geany] Adds newline even to...

[geany/geany] 3 propositions and 1...

scootergrisen

1 Mar 2018 1 Mar '18

1:11 p.m.

We have strings like: ``` _Fold All

_Unfold All

_Expand All

_Collapse All

Fold/unfold all children of a fold point

Fold or unfold all children of a fold point. By pressing the Shift key while clicking on a fold symbol the contrary behavior is used. ```

Perhaps they should all use collapse/expand. And perhaps use the same strings multiple places.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793

Attachments:

attachment.htm (text/html — 2.0 KB)

Show replies by date

elextr

1 Mar 1 Mar

1:18 p.m.

Please show where these strings are from, without any context its impossible to say.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793#issuecomment-369574392

scootergrisen

1:29 p.m.

![1](https://user-images.githubusercontent.com/1836590/36844819-7e43423c-1d54-11e...) ![2](https://user-images.githubusercontent.com/1836590/36844820-7e70d166-1d54-11e...)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793#issuecomment-369576714

Colomban Wendling

11:55 p.m.

Interesting point. Here, "fold" refers to hiding some part of the document, while "collapse" refers to a tree list view. Not sure if we should keep the distinction, or unify the similar concepts.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793#issuecomment-369759864

elextr

2 Mar 2 Mar

12:36 a.m.

Well, its a similar concept from differing domains, code editing, and tree viewing (commonly filesystems).

IME the former uses "fold/unfold" for the hiding of contiguous blocks of code whilst the latter uses "expand/collapse" for an information hierarchy. Certainly the underlying widgets do so:

http://www.scintilla.org/ScintillaDoc.html#Folding

https://developer.gnome.org/gtk3/stable/GtkTreeView.html#gtk-tree-view-expan...

Emacs, Qt creator use fold/unfold, Eclipse does not have folds on the text buffer, but shows the structure in a tree view in a separate pane and uses expand/collapse in that tree view to fold/unfold the text, yes it uses both terms to describe the action.

I think its fine for Geany to follow the historical usage and leave both terms.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793#issuecomment-369769244

Thomas Martitz

3 Apr 3 Apr

8:42 p.m.

I agree and would rather not change those terms, especially since they are in place since forever.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793#issuecomment-378354756

Thomas Martitz

8:42 p.m.

Closed #1793.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793#event-1554826984

2456

Age (days ago)

2489

Last active (days ago)

github-comments@lists.geany.org

6 comments

4 participants

tags (0)

participants (4)

Colomban Wendling
elextr
scootergrisen
Thomas Martitz