Fixes #1135, and may help for #1101 (?)
This also restores the custom selection color there too that got lost with GTK 3.20, and adds it to GTK2 too (for some reason it never was there). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1137
-- Commit Summary --
* Fix custom search entry background on Adwaita 3.20 * Restore custom selection color on no-match search entry on GTK3 * Set custom selection color on no-match search entry on GTK2
-- File Changes --
M data/geany.css (3) M data/geany.gtkrc (10)
-- Patch Links --
https://github.com/geany/geany/pull/1137.patch https://github.com/geany/geany/pull/1137.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137
@@ -20,6 +20,16 @@ widget "GeanyDialogSearch.*.geany-search-entry-no-match" style "geany-monospace" style "geany-search-entry-no-match-style" { base[NORMAL] = "#ffff66666666" text[NORMAL] = "#ffffffffffff"
- base[SELECTED] = "#777711111111"
- # try and remove the entry background image on pixmap engine so that our
- # background color is visible, and we don't end up with white text on white
- # background (workaround for Adwaita 3.20).
Why does this affect 3.20? I thought gtk3 didn't use the .gtkrc file?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137/files/13a9600ad7fad421497310d157233...
@@ -20,6 +20,16 @@ widget "GeanyDialogSearch.*.geany-search-entry-no-match" style "geany-monospace" style "geany-search-entry-no-match-style" { base[NORMAL] = "#ffff66666666" text[NORMAL] = "#ffffffffffff"
- base[SELECTED] = "#777711111111"
- # try and remove the entry background image on pixmap engine so that our
- # background color is visible, and we don't end up with white text on white
- # background (workaround for Adwaita 3.20).
*Adwaita* 3.20.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137/files/13a9600ad7fad421497310d157233...
Merged #1137.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#event-725052545
Maybe we should add this to a 1.28.1 release, as quite a few people are likely to suffer from that Adwaita issue?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#issuecomment-233101564
Would it be worth reporting the breakage to Adwaita also?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#issuecomment-233101702
As for 1.28.1 release, I have no opinion (except that Adwaita is ugly and I don't understand why anyone would use it :)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#issuecomment-233101867
Would it be worth reporting the breakage to Adwaita also?
I doubt they would care, but it'd be great if someone tried :)
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#issuecomment-233102105
Anybody knows how widely spread is the Adwaita theme outside from Fedora? If it affects Fedora only, I can back port the patch and a Geany release could wait then.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#issuecomment-233125741
Well, as its the default theme for Gnome I guess it is gonna be available on all Gnome distros, even if the distro defaults to its own hacked theme.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#issuecomment-233126556
@dmaphy as @elextr said, it's the default GNOME theme so it's likely to affect a lot of people. For example, it affects current Debian testing/unstable. OTOH, some widespread distros like Ubuntu ship with a custom theme by default, so they won't be affected by the same issues. Who knows if there are other there, though…
But yeah, I think it's likely to have a large impact, hence why I'm considering a point release might be a good idea. Either way you may want to backport the fix in Fedora until we release it, though, your call.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1137#issuecomment-233129090
github-comments@lists.geany.org