Related to #1116.
--- trivial enough I guess You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1185
-- Commit Summary --
* Allow to configure the error indicator color
-- File Changes --
M data/filedefs/filetypes.common (3) M doc/geany.txt (5) M src/highlighting.c (5)
-- Patch Links --
https://github.com/geany/geany/pull/1185.patch https://github.com/geany/geany/pull/1185.diff
I might be interesting to allow a theme to override the default, not sure.
@codebrainz @elextr opinions?
Looks OK at a glance, I haven't tested it though.
elextr commented on this pull request.
@@ -4593,6 +4593,11 @@ calltips
*Example:* ``calltips=0xc0c0c0;0xffffff;false;false``
+indicator_error + The color of the error indicator. +
Should mention only foreground field used.
One document suggestion, otherwise LGBI.
PS it probably would be good to make it themable, then a theme suitable for the colour challenged could be created.
b4n commented on this pull request.
@@ -4593,6 +4593,11 @@ calltips
*Example:* ``calltips=0xc0c0c0;0xffffff;false;false``
+indicator_error + The color of the error indicator. +
If you want, but as most of these settings use the value differently I thought "the color" was clear enough. Do you want me to add something like *"Only the first argument (foreground color) is used."*?
PS it probably would be good to make it themable, then a theme suitable for the colour challenged could be created.
Yes. I wanted to give it a shot, but it was more complex and only ended up with #1186, which still might be fairly useful to get in.
elextr commented on this pull request.
@@ -4593,6 +4593,11 @@ calltips
*Example:* ``calltips=0xc0c0c0;0xffffff;false;false``
+indicator_error + The color of the error indicator. +
Thats fine.
Merged #1185.
github-comments@lists.geany.org