 The same happens in the search window, and the window itself enlarges too. Font adjustment in the settings doesn't make a difference. Windows.
Doesn't happen on Linux, GTK2 or GTK3.
What version of Geany are you using and the version of gtk (near the top of help->debug messages)
Looks like a regression. It appears only in Geany 1.29, in Geany 1.28 the size is normal. Both versions tried with their bundled GTK 2.24.28 and with the latest GTK from MSYS2 (2.24.31).
Not sure if this is the issue however found the lines: engine "pixmap" { image { function = FLAT_BOX detail = "entry_bg" } } in geany.gtkrc lines 27 - 32 seems to be the issue on windows 10. When lines are commented out it seems to resolve the issue. Tested on ubuntu and windows 10 with genay 1.29. Is there any test that can be use to determine if this is not breaking the workaround in the comment above this code?
@dwledwards I guess testing it with the specified version of the Gnome theme, but since the comment says it was added to get around the way that theme works, simply removing the workaround will almost certainly break it again.
Unfortunately that makes the search entry unreadable with the default GTK theme and anything based on it, which is a worse problem than changing size of text, so unless there is another workaround for Adwaita then it should stay.
Unfortunately I don't believe gtkrc files have a way of limiting a setting to a specific theme and version.
Would it be an acceptable fix to perform the checking for windows in the ui_utils.c file and adding a new style for windows in the gtkrc.
I have modified ui_utils.c which defines ui_set_search_entry_background at line 1100 to check for OS:
#ifdef G_OS_WIN32 gtk_widget_set_name(widget, success ? NULL : "win-geany-search-entry-no-match"); #else gtk_widget_set_name(widget, success ? NULL : "geany-search-entry-no-match"); #endif
and then made the corresponding changes to the gtkrc file:
# set windows search to prevent widget "GeanyDialogSearch.*.win-geany-search-entry-no-match" style "geany-monospace"
# set red background for GtkEntries on windows showing unmatched searches style "win-geany-search-entry-no-match-style" { base[NORMAL] = "#ffff66666666" text[NORMAL] = "#ffffffffffff" } widget "*.win-geany-search-entry-no-match" style "win-geany-search-entry-no-match-style"
This seems to preserve the Adwaita workaround while fixing the issue on windows.
Seems reasonable to me, but I can't check on windows and the GTK-spurts such as @b4n should also comment.
@dwledwards I have taken the liberty of editing your post to enclose the code sections in lines containing three backquotes to stop Github interpreting code operators as markup.
github-comments@lists.geany.org