This fixes the issue where the property parser would never exist, causing @property directives to confuse Objective-C parsing. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/940
-- Commit Summary --
* Fix non-exiting property parser
-- File Changes --
M tagmanager/ctags/objc.c (1)
-- Patch Links --
https://github.com/geany/geany/pull/940.patch https://github.com/geany/geany/pull/940.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940
A unit test failed. Is this a problem?
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#issuecomment-193139892
@JX7P i guess you need to look at the parser tests and see why it now fails (assuming it has legal obj-c) and also add a test for your change.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#issuecomment-193180634
It seems to me to be the case that the unit test 'fails' because it never passed in the past, if I understand correctly that the testing is based on: * running the ctags on the file, and comparing the output of this ctags run to that which is in the .tags file
The objectivec_property.mm already tests for what this fixes; only now it will require its .tags regenerating in line with the newly corrected output.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#issuecomment-193191077
Then this should just be a matter of updating the test.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#issuecomment-193192877
@@ -1,4 +1,5 @@ # format=tagmanager -Person�32�0 -m_age�8�Person�0 -m_name�8�Person�0 +PersonÌ32Ö0 +initWithAge:Ì128ÎPersonÖ0 +m_ageÌ8ÎPersonÖ0 +m_nameÌ8ÎPersonÖ0
encoding issues here (yeah it's binary, sorry)
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940/files#r55189502
Changes look fair enough.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#issuecomment-193207165
Hum, I see this is also fixed in universal-ctags in universal-ctags/ctags@21e74e6a019975045a7975bc611ae63f0917f976 I'll import this patch and your test case update
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#issuecomment-193209027
@JX7P could you please test #941? it includes the same fix from u-ctags, your update of the test case, and a few other fixes (incl. a memleak fix).
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#issuecomment-193221010
Closed #940 via #941.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/940#event-580146461
github-comments@lists.geany.org