Move plugin layout to session.conf
The plugin related settings can be considered session data. They encode local paths that wouldn't work on other machines. Also I would say it's not unusual to have a different set of plugins enabled on a different machine.
The "load_pluings" key is moved as well to keep things simple. No idea what's the use case to set this off. Typically you just have no plugins enabled and the debugging aid `geany -p` bypasses any of this anyway. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3183
-- Commit Summary --
* session.conf split follow-up: plugins
-- File Changes --
M src/keyfile.c (14) M src/keyfile.h (2) M src/plugins.c (2) M src/search.c (2) M src/sidebar.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/3183.patch https://github.com/geany/geany/pull/3183.diff
I agree that these are session data and the changes LGBI.
Merged #3183 into master.
The "load_pluings" key is moved as well to keep things simple. No idea what's the use case to set this off. Typically you just have no plugins enabled and the debugging aid geany -p bypasses any of this anyway.
I don't remember why we added it (it was probably me). Maybe this is from the very early days with plugin support where we were maybe not sure if it is stable enough.
Apart from that, I have also no idea why the setting was added.
The changes look good to me and work.
More a general question: I didn't follow the previous session split PRs closely, so I missed the answer to the question: do we have a plan to support the user in migrating the settings in some way?
Currently, the old settings are still in geany.conf but ignored, i.e. users will loose e.g. their list of activated plugins.
@kugel- @elextr did you see the comment above?
Except from the fact that it was merged while I was testing it, the question about user migration still stands for me.
Err, I'm sorry, I was sure that I had answered your question by email but I can't find it myself.
There is a one-time migration plan: If session.conf does not exist, then the same keys will be read from geany.conf. That covers users upgrading from 1.38 (or earlier) to 1.39/2.0, so almost all users. There is no plan yet for the time after (I hope to complete the transition before the final realease). There is no plan for git master users.
Sounds good. I added a corresponding TODO note on "session split" project.
I agree we do not need a plan for GIT master users.
github-comments@lists.geany.org