I built Geany with GTK3 and try under default theme of Ubuntu. Looking in the tab, I cannot see which one is active.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1156
This is likely to be related to the theme. Geany does not specify what an active tab looks like (see [geany.css](https://github.com/geany/geany/blob/master/data/geany.css)), so whatever the theme defines will be used.
On my Mint (Ubuntu based) system with GTK 3.18.9, the active tab is clearly defined with an out-of-the-box Geany.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1156#issuecomment-236423367
I want to contribute a patch to [geany-3.0.css](https://github.com/geany/geany/blob/master/data/geany-3.0.css) to make it look better, like this
Is it OK?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1156#issuecomment-236424830
Best to make a pull request, but it should not interfere with themes on systems where it currently works.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1156#issuecomment-236427339
As we don't style the tabs, it's IMO not our problem but the Ubuntu's theme one. How does other apps look like? FWIW, the default GTK3 theme works just fine in that regard.
And as @elextr's pointed out, *if* we did anything, it would have to be compatible with *any* theme -- or specific to one, if that's even possible. It wouldn't be acceptable to e.g. set a background color ourselves, as it would conflict with all themes.
And BTW, I don't see much difference between the 2 captures. I don't think it's a worthy improvement if it's still that subtle to distinguish.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1156#issuecomment-236430378
Closed #1156.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1156#event-740272480
github-comments@lists.geany.org