On Windows Scope doesn't need neither VTE nor pty.h, so drop the incorrect checks there. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/409
-- Commit Summary --
* scope: Fix dependencies checks on Windows
-- File Changes --
M build/scope.m4 (19)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/409.patch https://github.com/geany/geany-plugins/pull/409.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409
@eht16 @kugel- could you try this on Windows and if it does work, merge it?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409#issuecomment-227289365
I think I tried it in March but forgot to give feedback: IIRC the changes are fine and Scope builds. Though the plugin is of limited use on Windows because you cannot define the path to the `gdb` executable, Scope expects to find `gdb.exe` in $PATH. But having Scope built and distributed at all surely would be better than now.
I will test this in the next days again to get sure but before I need to rebuild everything with GTK2 for Scope (no GTK3 support).
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409#issuecomment-227297619
Though the plugin is of limited use on Windows because you cannot define the path to the gdb executable,
And unless it's been fixed since I last used it, it doesn't work on non-`C:` drives, which is a drag when all your source code lives on a data drive or network share :(
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409#issuecomment-227308418
This PR works: Scope can be built fine on Windows after applying the changes.
As mentioned, Scope expects gdb.exe to be available in $PATH and probably also what @codebrainz reported (I didn't test).
Do we want to ship Scope in the Windows installer anyway? If so, just merge it.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409#issuecomment-228169075
I don't care at all (last time I tried to test Scope on Linux it didn't seem to work, but maybe I was doing something wrong, and I didn't search further). The PR here wasn't made in a hope to get it so I can use it on Windows, but merely to get things "more right".
IMO if this fixes the build, it should be merged, and whether or not it is included in the installer could be another question. But I don't have any real opinion actually.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409#issuecomment-228170342
Merged #409.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409#event-702490203
Do we want to ship Scope in the Windows installer anyway?
Both issues have simple-enough workarounds. IMO, if it's the only working debugging plugin on Windows, it'd probably be worth leaving it in.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/409#issuecomment-228219722
github-comments@lists.geany.org