Seems to be working (at least on Linux), not tested much. This doesn't add any functionality, though it's necessary if we want to add the other features at some point.
@codebrainz @elextr You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3417
-- Commit Summary --
* Move GTK calls out of parse_command_line_options * Use GtkApplication
-- File Changes --
M src/libmain.c (61)
-- Patch Links --
https://github.com/geany/geany/pull/3417.patch https://github.com/geany/geany/pull/3417.diff
Ping @b4n @techee (for OSX) @eht16 (for windows) as well.
GtkAction has been deprecated. Use GAction instead
GtkApplication is needed to fix that AFAIU. Or just to avoid using the deprecated API in any new code.
No, you can use GAction without. And I'm not against GtkApplication, but we should then embrace it rather than fight it, otherwise I really don't see the point.
Seems to work on macOS without any problems. And I agree that we should start using GtkApplication (if, in the far future, we switch to GMenuModel for menus, we could avoid using the mac-integration library because the global menu should be then handled by GtkApplication).
but we should then embrace it rather than fight it, otherwise I really don't see the point.
Can we embrace it in small steps?
@techee Thanks for testing!
github-comments@lists.geany.org